All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>, Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 7/8] W1: u64 is not long long
Date: Thu, 23 Mar 2006 17:30:38 -0800	[thread overview]
Message-ID: <11431638383855-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <11431638372371-git-send-email-gregkh@suse.de>

You don't know what type a u64 is, hence you cannot print it without a cast.

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---

 drivers/w1/w1.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

f73b5e7949945486a649e40821cd351e2f60bf02
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 5def7fb..d640c1e 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -388,11 +388,14 @@ static int w1_uevent(struct device *dev,
 	if (dev->driver != &w1_slave_driver || !sl)
 		return 0;
 
-	err = add_uevent_var(envp, num_envp, &cur_index, buffer, buffer_size, &cur_len, "W1_FID=%02X", sl->reg_num.family);
+	err = add_uevent_var(envp, num_envp, &cur_index, buffer, buffer_size,
+			&cur_len, "W1_FID=%02X", sl->reg_num.family);
 	if (err)
 		return err;
 
-	err = add_uevent_var(envp, num_envp, &cur_index, buffer, buffer_size, &cur_len, "W1_SLAVE_ID=%024LX", (u64)sl->reg_num.id);
+	err = add_uevent_var(envp, num_envp, &cur_index, buffer, buffer_size,
+			&cur_len, "W1_SLAVE_ID=%024LX",
+			(unsigned long long)sl->reg_num.id);
 	if (err)
 		return err;
 
-- 
1.2.4



  reply	other threads:[~2006-03-24  1:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <11431638372037-git-send-email-gregkh@suse.de>
2006-03-24  1:30 ` [PATCH 3/8] W1: Add the DS2482 I2C-to-w1 bridge driver Greg KH
2006-03-24  1:30   ` [PATCH 4/8] w1: misc cleanups Greg KH
2006-03-24  1:30     ` [PATCH 5/8] fix W1_MASTER_DS9490_BRIDGE dependencies Greg KH
2006-03-24  1:30       ` [PATCH 6/8] W1: Remove incorrect MODULE_ALIAS Greg KH
2006-03-24  1:30         ` Greg KH [this message]
2006-03-24  1:30           ` [PATCH 8/8] w1: use kthread api Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11431638383855-git-send-email-gregkh@suse.de \
    --to=gregkh@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.