All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darren Jenkins\\" <darrenrjenkins@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ][Patch][update] fix kbuild warning in iptable_nat.o
Date: Wed, 29 Mar 2006 09:48:14 +0000	[thread overview]
Message-ID: <1143625694.7779.18.camel@localhost.localdomain> (raw)
In-Reply-To: <1143548373.14792.9.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

On Tue, 2006-03-28 at 09:06 -0800, Nishanth Aravamudan wrote:
> On 28.03.2006 [23:19:33 +1100], Darren Jenkins" wrote:
> 
> <snip>
> 
> > As iptable_nat.o seems to be compiled into the kernel (from
> > ip_nat_rule.c and ip_nat_standalone.c) by default, I don't think we need
> > the __exit function (correct me if I am wrong).
> 
> <snip>
> 
> What happens when we do build NAT filtering support as a module? Just
> because the default is non-modular, does not mean we can ignore the
> option.
> 
> Thanks,
> Nish
> 

Actually I thought that as in the Makefile, it does not depend on any
config options to be built. That it would only ever be compiled into the
kernel.
Thinking about it, I guess it could be a module in the next higher level
Makefile, and I should probably read up on how a Makefile works
anyway. :)

Darren J.


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2006-03-29  9:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-28 12:19 [KJ][Patch][update] fix kbuild warning in iptable_nat.o Darren Jenkins\
2006-03-28 17:06 ` Nishanth Aravamudan
2006-03-28 17:18 ` Randy.Dunlap
2006-03-28 17:45 ` Randy.Dunlap
2006-03-28 18:07 ` Randy.Dunlap
2006-03-29  9:48 ` Darren Jenkins\ [this message]
2006-03-31 13:13 ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1143625694.7779.18.camel@localhost.localdomain \
    --to=darrenrjenkins@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.