From: Tejun Heo <htejun@gmail.com>
To: jgarzik@pobox.com, alan@lxorguk.ukuu.org.uk, albertcc@tw.ibm.com,
linux-ide@vger.kernel.org
Cc: Tejun Heo <htejun@gmail.com>
Subject: [PATCH] libata: add per-dev ata_ering
Date: Mon, 3 Apr 2006 12:40:58 +0900 [thread overview]
Message-ID: <11440356581662-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: <11440356574107-git-send-email-htejun@gmail.com>
EH is gonna record errors per-dev. Define per-dev ata_ering.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/scsi/libata-core.c | 1 +
include/linux/libata.h | 4 ++++
2 files changed, 5 insertions(+), 0 deletions(-)
ca065c0f8bb2d545dc3abe83101c4d714f72dee9
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index fc9ae17..e6dec59 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -4762,6 +4762,7 @@ static void ata_host_init(struct ata_por
dev->pio_mask = UINT_MAX;
dev->mwdma_mask = UINT_MAX;
dev->udma_mask = UINT_MAX;
+ ata_ering_init(&dev->ering, ATA_DEV_ERING_SIZE);
}
#ifdef ATA_IRQ_TRAP
diff --git a/include/linux/libata.h b/include/linux/libata.h
index e4480f2..7eeb023 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -136,6 +136,8 @@ enum {
ATA_DEV_ATAPI_UNSUP = 4, /* ATAPI device (unsupported) */
ATA_DEV_NONE = 5, /* no device */
+ ATA_DEV_ERING_SIZE = 32, /* record 32 recent errors */
+
/* struct ata_port flags */
ATA_FLAG_SLAVE_POSS = (1 << 0), /* host supports slave dev */
/* (doesn't imply presence) */
@@ -412,6 +414,8 @@ struct ata_device {
u16 cylinders; /* Number of cylinders */
u16 heads; /* Number of heads */
u16 sectors; /* Number of sectors per track */
+
+ DEFINE_ATA_ERING (ering, ATA_DEV_ERING_SIZE);
};
struct ata_port {
--
1.2.4
next prev parent reply other threads:[~2006-04-03 3:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-03 3:40 [PATCHSET] new EH implementation Tejun Heo
2006-04-03 3:40 ` [PATCH] libata: add constants and flags to be used by EH Tejun Heo
2006-04-03 3:40 ` [PATCH] libata: implement ata_ering Tejun Heo
2006-04-03 3:40 ` [PATCH] libata: implement EH methods for BMDMA controllers Tejun Heo
2006-04-03 3:40 ` [PATCH] libata: implement ata_eh_revive() Tejun Heo
2006-04-03 3:40 ` [PATCH] libata: implement ata_eh_determine_qc() Tejun Heo
2006-04-03 3:40 ` [PATCH] libata: implement ata_eh_report() Tejun Heo
2006-04-03 3:40 ` [PATCH] libata: implement ata_eh_finish_qcs() Tejun Heo
2006-04-03 3:40 ` [PATCH] libata: implement ata_eh_autopsy() Tejun Heo
2006-04-03 3:40 ` [PATCH] ata_piix: convert to new EH Tejun Heo
2006-04-03 3:40 ` [PATCH] libata: implement EH utility functions Tejun Heo
2006-04-03 3:40 ` Tejun Heo [this message]
2006-04-03 3:40 ` [PATCH] sata_sil: convert to new EH Tejun Heo
2006-04-03 3:40 ` [PATCH] ahci: " Tejun Heo
2006-04-03 3:43 ` [PATCHSET] new EH implementation Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11440356581662-git-send-email-htejun@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.