From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian McMenamin Subject: Re: Re: Patch for AICA sound support on SEGA Dreamcast Date: Tue, 04 Apr 2006 08:12:02 +0100 Message-ID: <1144134722.9270.4.camel@localhost.localdomain> References: <1144075522.11511.20.camel@localhost.localdomain> <443162B4.60500@kenati.com> <200604040116.13732.s0348365@sms.ed.ac.uk> <1144110986.22082.4.camel@mindpipe> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1144110986.22082.4.camel@mindpipe> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Lee Revell Cc: Alistair John Strachan , Takashi Iwai , Carlos Munoz , Alsa-devel , linux-sh , Paul Mundt , LKML List-Id: alsa-devel@alsa-project.org On Mon, 2006-04-03 at 20:36 -0400, Lee Revell wrote: > On Tue, 2006-04-04 at 01:16 +0100, Alistair John Strachan wrote: > > I think this write-up provides justification. However, it is not part > > of linux/Documentation/CodingStyle. Perhaps somebody should add these > > details to this file, so that new code follows this currently > > 'unwritten' rule. > > Well, if you look at the current ALSA code, the only typedefs provided > are for backwards compatibility. They were all removed from the drivers > months ago. The problem is that you were working against old code. The > main coding style rule is to follow the conventions of the nearby code, > which would mean no typedefs in the ALSA driver case. > Well, the typedefs are going - look in my personal CVS (http://newgolddream.dyndns.info/cgi-bin/cvsweb ) and you'll see that most are now gone. I wrote the code, however, against the 2.6.15 kernel, not an unreasonable proposition given that it was the current kernel until about 2 weeks ago. ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642