From: Carlos Silva <r3pek@r3pek.homelinux.org>
To: Yi Yang <yang.y.yi@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
Matt Helsley <matthltc@us.ibm.com>
Subject: Re: [2.6.16 PATCH] Filessytem Events Reporter V2
Date: Wed, 05 Apr 2006 18:12:04 +0100 [thread overview]
Message-ID: <1144257124.2075.10.camel@localhost> (raw)
In-Reply-To: <4433C456.7010708@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
On Wed, 2006-04-05 at 21:21 +0800, Yi Yang wrote:
> <snip>
> +static void cleanup_dead_listener(listener * x)
> +{
> + pid_filter * p = NULL, * pq = NULL;
> + uid_filter * u = NULL, * uq = NULL;
> + gid_filter * g = NULL, * gq = NULL;
> +
> + if (p == NULL)
> + return;
> <snip>
I think you ment "if (x == NULL)" here. Otherwise, the condition will always be true.
btw, I'm not reviewing your code, just stumbled across this while reading it.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 200 bytes --]
next prev parent reply other threads:[~2006-04-05 16:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-05 13:21 [2.6.16 PATCH] Filessytem Events Reporter V2 Yi Yang
2006-04-05 17:12 ` Carlos Silva [this message]
2006-04-05 23:45 ` Yi Yang
2006-04-07 6:24 ` Evgeniy Polyakov
2006-04-07 8:13 ` Yi Yang
2006-04-07 9:47 ` Evgeniy Polyakov
2006-04-07 10:03 ` Yi Yang
2006-04-07 10:26 ` Evgeniy Polyakov
2006-04-07 15:14 ` Yi Yang
2006-04-07 19:47 ` Evgeniy Polyakov
2006-04-07 20:27 ` Evgeniy Polyakov
-- strict thread matches above, loose matches on Subject: below --
2006-04-05 14:13 Michael Guo
2006-04-05 23:44 ` Yi Yang
2006-04-06 14:34 Michael Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1144257124.2075.10.camel@localhost \
--to=r3pek@r3pek.homelinux.org \
--cc=akpm@osdl.org \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=yang.y.yi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.