From: Tejun Heo <htejun@gmail.com>
To: jgarzik@pobox.com, linux-ide@vger.kernel.org,
Carlos.Pardo@siliconimage.com
Cc: Tejun Heo <htejun@gmail.com>
Subject: [PATCH 12/13] sata_sil24: fix on-memory structure byteorder
Date: Fri, 7 Apr 2006 17:16:54 +0900 [thread overview]
Message-ID: <11443978143342-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: <114439781363-git-send-email-htejun@gmail.com>
Data structures residing on memory and fetched by the controller
should have LE ordering. Fix it.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/scsi/sata_sil24.c | 13 ++++++-------
1 files changed, 6 insertions(+), 7 deletions(-)
c65a82b53f25bf7ef1c5d08d65c34770fd5bc55c
diff --git a/drivers/scsi/sata_sil24.c b/drivers/scsi/sata_sil24.c
index 46c0f2a..0b96ab1 100644
--- a/drivers/scsi/sata_sil24.c
+++ b/drivers/scsi/sata_sil24.c
@@ -482,7 +482,7 @@ static int sil24_softreset(struct ata_po
}
/* do SRST */
- prb->ctrl = PRB_CTRL_SRST;
+ prb->ctrl = cpu_to_le16(PRB_CTRL_SRST);
prb->fis[1] = 0; /* no PM yet */
writel((u32)paddr, port + PORT_CMD_ACTIVATE);
@@ -598,6 +598,7 @@ static void sil24_qc_prep(struct ata_que
union sil24_cmd_block *cb = pp->cmd_block + qc->tag;
struct sil24_prb *prb;
struct sil24_sge *sge;
+ u16 ctrl = 0;
switch (qc->tf.protocol) {
case ATA_PROT_PIO:
@@ -605,7 +606,6 @@ static void sil24_qc_prep(struct ata_que
case ATA_PROT_NODATA:
prb = &cb->ata.prb;
sge = cb->ata.sge;
- prb->ctrl = 0;
break;
case ATA_PROT_ATAPI:
@@ -618,12 +618,10 @@ static void sil24_qc_prep(struct ata_que
if (qc->tf.protocol != ATA_PROT_ATAPI_NODATA) {
if (qc->tf.flags & ATA_TFLAG_WRITE)
- prb->ctrl = PRB_CTRL_PACKET_WRITE;
+ ctrl = PRB_CTRL_PACKET_WRITE;
else
- prb->ctrl = PRB_CTRL_PACKET_READ;
- } else
- prb->ctrl = 0;
-
+ ctrl = PRB_CTRL_PACKET_READ;
+ }
break;
default:
@@ -632,6 +630,7 @@ static void sil24_qc_prep(struct ata_que
BUG();
}
+ prb->ctrl = cpu_to_le16(ctrl);
ata_tf_to_fis(&qc->tf, prb->fis, 0);
if (qc->flags & ATA_QCFLAG_DMAMAP)
--
1.2.4
next prev parent reply other threads:[~2006-04-07 8:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 8:16 [PATCHSET] sata_sil24: fixes, errata workaround and reset updates, take 2 Tejun Heo
2006-04-07 8:16 ` [PATCH 01/13] libata: export ata_set_sata_spd() Tejun Heo
2006-04-07 8:16 ` [PATCH 06/13] sata_sil24: implement loss of completion interrupt on PCI-X errta fix Tejun Heo
2006-04-11 8:34 ` [PATCH 06/13 (updated)] " Tejun Heo
2006-04-11 9:11 ` Tejun Heo
2006-04-07 8:16 ` [PATCH 05/13] sata_sil24: consolidate host flags into SIL24_COMMON_FLAGS Tejun Heo
2006-04-07 8:16 ` [PATCH 03/13] sata_sil24: rename PORT_IRQ_SDB_FIS to PORT_IRQ_SDB_NOTIFY Tejun Heo
2006-04-07 8:16 ` [PATCH 07/13] sata_sil24: implement sil24_init_port() Tejun Heo
2006-04-07 8:16 ` [PATCH 08/13] sata_sil24: put port into known state before softresetting Tejun Heo
2006-04-07 8:16 ` [PATCH 02/13] sata_sil24: typo fix Tejun Heo
2006-04-07 8:16 ` [PATCH 04/13] sata_sil24: add more constants Tejun Heo
2006-04-07 8:16 ` [PATCH 11/13] sata_sil24: don't do hardreset during driver initialization Tejun Heo
2006-04-07 8:16 ` [PATCH 10/13] sata_sil24: reimplement hardreset Tejun Heo
2006-04-07 8:16 ` [PATCH 13/13] sata_sil24: enable 64bit Tejun Heo
2006-04-07 8:16 ` Tejun Heo [this message]
2006-04-07 8:16 ` [PATCH 09/13] sata_sil24: kill 10ms sleep in softreset Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2006-04-11 13:32 [PATCHSET 4/9] sata_sil24 fixes, errata workaround and reset updates, take 3 Tejun Heo
2006-04-11 13:32 ` [PATCH 12/13] sata_sil24: fix on-memory structure byteorder Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11443978143342-git-send-email-htejun@gmail.com \
--to=htejun@gmail.com \
--cc=Carlos.Pardo@siliconimage.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.