Return-Path: Received: from mwinf3001.me.freeserve.com (mwinf3001.me.freeserve.com) by mwinb3203 (SMTP Server) with LMTP; Fri, 07 Apr 2006 09:31:16 +0200 X-Sieve: Server Sieve 2.2 Envelope-to: harry@hebutterworth.freeserve.co.uk Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3001.me.freeserve.com (SMTP Server) with ESMTP id B37F31C03F28 for ; Fri, 7 Apr 2006 09:31:16 +0200 (CEST) Received: from lists.xensource.com (vm04-bcn-london.deploy.xenoserver.org [217.147.82.229]) by mwinf3001.me.freeserve.com (SMTP Server) with ESMTP id 9D3441C03F2D for ; Fri, 7 Apr 2006 09:31:16 +0200 (CEST) X-ME-UUID: 20060407073116644.9D3441C03F2D@mwinf3001.me.freeserve.com Received: from localhost ([127.0.0.1] helo=lists.xensource.com) by host-192-168-0-1-bcn-london with esmtp (Exim 4.50) id 1FRlSY-0004VG-St; Fri, 07 Apr 2006 07:32:46 +0000 Received: from [192.168.0.10] (helo=lists.xensource.com) by host-192-168-0-1-bcn-london with esmtp (Exim 4.50) id 1FRlS8-0004Hu-Gf for xen-devel@lists.xensource.com; Fri, 07 Apr 2006 07:32:20 +0000 Received: from mta2.cl.cam.ac.uk ([128.232.0.14] ident=[nwQPMjGpWgHmOF+GzN7+VeyGeX/BLTa0]) by lists.xensource.com with esmtp (Exim 4.50) id 1FRlHz-0003bc-0H for xen-devel@lists.xensource.com; Fri, 07 Apr 2006 07:21:51 +0000 Received: from c019.vpn.cl.cam.ac.uk ([128.232.105.19]) by mta2.cl.cam.ac.uk with esmtp (Exim 3.092 #1) id 1FRlQc-0002bT-00; Fri, 07 Apr 2006 08:30:46 +0100 In-Reply-To: <1144358555.4775.10.camel@localhost> References: <1144348570.7725.9.camel@localhost.localdomain> <20060406184602.GB20687@granada.merseine.nu> <1144349930.21520.4.camel@localhost.localdomain> <20060406190647.GC20687@granada.merseine.nu> <1144358555.4775.10.camel@localhost> Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <461bea0b36f0398882dec8610f691f54@cl.cam.ac.uk> From: Keir Fraser Date: Fri, 7 Apr 2006 08:27:50 +0100 To: Harry Butterworth X-Mailer: Apple Mail (2.623) X-SA-Exim-Connect-IP: 128.232.0.14 X-SA-Exim-Mail-From: keir.fraser@cl.cam.ac.uk X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on (none) X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.1.0 Subject: Re: [Xen-devel] [RFC][PATCH] allow dom0 to power off machine using ACPI on shutdown. X-SA-Exim-Version: 4.2 (built Thu, 03 Mar 2005 10:44:12 +0100) X-SA-Exim-Scanned: Yes (on lists.xensource.com) Cc: xen-devel@lists.xensource.com X-BeenThere: xen-devel@lists.xensource.com X-Mailman-Version: 2.1.5 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com X-me-spamlevel: not-spam X-me-spamrating: 0.071921 Content-Transfer-Encoding: 7bit On 6 Apr 2006, at 22:22, Harry Butterworth wrote: > It might be better to install the hypervisor call in pm_power_off and > let it get replaced by the acpi_power_off call if ACPI is detected. > That would seem to fit in better with the way the x86 arch handles > multiple power off strategies. > > I haven't looked to see how the other architectures do power off yet. > > Was hoping for some comment about whether to do power off in xen or in > domU and whether the hypervisor needed notification. I think your patch looked okay for now, actually. Alternatively our machine_restart() could be moved into arch-specific code files. Doing the power off in dom0 is fine -- as you say, Xen doesn't do anyhting special before shutdown. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel