From: Eric Sesterhenn <snakebyte@gmx.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: acme@conectiva.com.br
Subject: [Patch] leak in net/dccp/ipv4.c
Date: Tue, 11 Apr 2006 00:07:26 +0200 [thread overview]
Message-ID: <1144706846.31667.1.camel@alice> (raw)
hi,
we dont free req if we cant parse the options.
This fixes coverity bug id #1046
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-rc1/net/dccp/ipv4.c.orig 2006-04-11 00:05:39.000000000 +0200
+++ linux-2.6.17-rc1/net/dccp/ipv4.c 2006-04-11 00:06:08.000000000 +0200
@@ -498,7 +498,7 @@ int dccp_v4_conn_request(struct sock *sk
goto drop;
if (dccp_parse_options(sk, skb))
- goto drop;
+ goto drop_and_free;
dccp_openreq_init(req, &dp, skb);
next reply other threads:[~2006-04-10 22:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-10 22:07 Eric Sesterhenn [this message]
2006-04-10 23:43 ` [Patch] leak in net/dccp/ipv4.c David S. Miller
2006-04-11 0:04 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1144706846.31667.1.camel@alice \
--to=snakebyte@gmx.de \
--cc=acme@conectiva.com.br \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.