From: Tejun Heo <htejun@gmail.com>
To: jgarzik@pobox.com, alan@lxorguk.ukuu.org.uk, axboe@suse.de,
albertcc@tw.ibm.com, lkosewsk@gmail.com,
linux-ide@vger.kernel.org
Cc: Tejun Heo <htejun@gmail.com>
Subject: [PATCH 06/13] libata-hp: prepare for persistent device flags
Date: Tue, 11 Apr 2006 23:06:21 +0900 [thread overview]
Message-ID: <11447643811744-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: <11447643813451-git-send-email-htejun@gmail.com>
This patch makes dev->flags persistent, defines ATA_DFLAG_INIT_MASK as
lower 16 bits of device flags and clear them in ata_dev_init(). So,
device flags in bits [0:15] are cleared over hotplugging while flags
from bit 16 upward are maintained.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/scsi/libata-core.c | 2 ++
include/linux/libata.h | 3 ++-
2 files changed, 4 insertions(+), 1 deletions(-)
3a7b8630e4c5cc409562164a941b40bc2b6b8728
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index 09e82f9..930f387 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -1444,6 +1444,8 @@ err_out_nosup:
*/
static void ata_dev_init(struct ata_port *ap, struct ata_device *dev)
{
+ dev->flags &= ~ATA_DFLAG_INIT_MASK;
+
memset((void *)dev + ATA_DEVICE_CLEAR_OFFSET, 0,
sizeof(*dev) - ATA_DEVICE_CLEAR_OFFSET);
dev->pio_mask = UINT_MAX;
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 809f3b9..33ce8a4 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -128,6 +128,7 @@ enum {
ATA_DFLAG_PIO = (1 << 8), /* device currently in PIO mode */
ATA_DFLAG_FAILED = (1 << 9), /* device has failed */
+ ATA_DFLAG_INIT_MASK = (1 << 16) - 1,
ATA_DEV_UNKNOWN = 0, /* unknown device */
ATA_DEV_ATA = 1, /* ATA device */
@@ -396,9 +397,9 @@ struct ata_ering {
struct ata_device {
unsigned int devno; /* 0 or 1 */
+ unsigned long flags; /* ATA_DFLAG_xxx */
/* fields above n_sectors are not cleared across device init */
u64 n_sectors; /* size of device, if ATA */
- unsigned long flags; /* ATA_DFLAG_xxx */
unsigned int class; /* ATA_DEV_xxx */
u16 *id; /* IDENTIFY xxx DEVICE data */
u8 pio_mode;
--
1.2.4
next prev parent reply other threads:[~2006-04-11 14:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-11 14:06 [PATCHSET 8/9] prep for hotplug support Tejun Heo
2006-04-11 14:06 ` [PATCH 01/13] libata-hp: separate out __ata_scsi_find_dev() Tejun Heo
2006-04-11 14:06 ` [PATCH 08/13] libata-hp: move device enable/disable out of ata_bus_probe() Tejun Heo
2006-04-11 14:06 ` [PATCH 04/13] libata-hp: make some fields of ata_device persistent Tejun Heo
2006-04-11 14:06 ` [PATCH 07/13] libata-hp: implement ap->orig_sata_spd_limit Tejun Heo
2006-04-27 9:19 ` Jeff Garzik
2006-04-27 10:18 ` Tejun Heo
2006-04-11 14:06 ` Tejun Heo [this message]
2006-04-11 14:06 ` [PATCH 03/13] libata-hp: implement ata_dev_init() Tejun Heo
2006-04-11 14:06 ` [PATCH 02/13] libata-hp: add more SERR_* constants in preparation for hotplug support Tejun Heo
2006-04-11 14:06 ` [PATCH 05/13] libata-hp: call ata_dev_init() from ata_bus_probe() Tejun Heo
2006-04-11 14:06 ` [PATCH 12/13] libata-hp: store attached SCSI device Tejun Heo
2006-04-27 9:20 ` Jeff Garzik
2006-04-11 14:06 ` [PATCH 11/13] libata-hp: add hotplug flags and flag handling functions Tejun Heo
2006-04-11 14:06 ` [PATCH 13/13] libata-hp: add ata_hotplug_wq Tejun Heo
2006-04-13 6:11 ` zhao, forrest
2006-04-13 6:33 ` Tejun Heo
2006-04-11 14:06 ` [PATCH 09/13] libata-hp: prepare ata_bus_probe() for hotplug Tejun Heo
2006-04-11 14:06 ` [PATCH 10/13] libata-hp: make ata_bus_probe() extern Tejun Heo
2006-04-12 1:41 ` [PATCHSET 8/9] prep for hotplug support Tejun Heo
2006-04-27 9:22 ` Jeff Garzik
2006-04-27 10:27 ` Tejun Heo
2006-04-27 10:36 ` Jeff Garzik
2006-04-27 10:47 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11447643811744-git-send-email-htejun@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=axboe@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=lkosewsk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.