All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sesterhenn <snakebyte@gmx.de>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [Patch] cleanup inode->r_dev usage in drivers/block/loop.c
Date: Wed, 12 Apr 2006 14:58:35 +0000	[thread overview]
Message-ID: <1144853915.7840.11.camel@alice> (raw)
In-Reply-To: <1144790741.13849.2.camel@alice>

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

hi,

imajor()/iminor() should be used instead of accessing r_dev
directly. This patch cleans up drivers/block/loop.c

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

--- linux-2.6.17-rc1-git5/drivers/block/loop.c.orig	2006-04-12 13:50:23.000000000 +0200
+++ linux-2.6.17-rc1-git5/drivers/block/loop.c	2006-04-12 13:50:46.000000000 +0200
@@ -734,7 +734,7 @@ static inline int is_loop_device(struct 
 {
 	struct inode *i = file->f_mapping->host;
 
-	return i && S_ISBLK(i->i_mode) && MAJOR(i->i_rdev) == LOOP_MAJOR;
+	return i && S_ISBLK(i->i_mode) && imajor(i) == LOOP_MAJOR;
 }
 
 static int loop_set_fd(struct loop_device *lo, struct file *lo_file,



[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2006-04-12 14:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-11 21:25 [KJ] [Patch] cleanup inode->r_dev usage in arch/cris Eric Sesterhenn
2006-04-12 14:58 ` [KJ] [Patch] cleanup inode->r_dev usage in Eric Sesterhenn
2006-04-12 14:58 ` Eric Sesterhenn
2006-04-12 14:58 ` Eric Sesterhenn [this message]
2006-04-12 14:58 ` [KJ] [Patch] cleanup inode->r_dev usage in arch/mips Eric Sesterhenn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1144853915.7840.11.camel@alice \
    --to=snakebyte@gmx.de \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.