From: Mike Galbraith <efault@gmx.de>
To: maeda.naoaki@jp.fujitsu.com
Cc: linux-kernel@vger.kernel.org, ckrm-tech@lists.sourceforge.net
Subject: Re: [RFC][PATCH 5/9] CPU controller - Documents how the controller works
Date: Sun, 23 Apr 2006 09:13:50 +0200 [thread overview]
Message-ID: <1145776430.7990.58.camel@homer> (raw)
In-Reply-To: <20060421022753.13598.77686.sendpatchset@moscone.dvs.cs.fujitsu.co.jp>
On Fri, 2006-04-21 at 11:27 +0900, maeda.naoaki@jp.fujitsu.com wrote:
> +3. Timeslice scaling
> +
> + If there are hungry classes, we need to adjust timeslices to satisfy
> + the share. To scale timeslices, we introduce a scaling factor
> + used for scaling timeslices. The scaling factor is associated with
> + the class (stored in the cpu_rc structure) and adaptively adjusted
> + according to the class load and the share.
This all works fine until interactive task requeueing is considered, and
it must be considered.
One simple way to address the requeue problem is to introduce a scaled
class sleep_avg consumption factor. Remove the scaling exemption for
TASK_INTERACTIVE(p), and if a class's cpu usage doesn't drop to what is
expected by group timeslice scaling, make members consume sleep_avg at a
higher rate such that scaling can take effect.
A better way to achieve the desired group cpu usage IMHO would be to
adjust nice level of members at slice refresh time. This way, you get
the timeslice scaling and priority adjustment all in one.
(I think I would do both actually, with nice level being preferred such
that dynamic priority spread within the group isn't flattened, which can
cause terminal starvation within the group, unless really required.)
-Mike
next prev parent reply other threads:[~2006-04-23 7:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 2:27 [RFC][PATCH 0/9] CKRM CPU resource controller maeda.naoaki
2006-04-21 2:27 ` [RFC][PATCH 1/9] CPU controller - Adds class load estimation maeda.naoaki
2006-04-21 2:27 ` [RFC][PATCH 2/9] CPU controller - Adds class hungry detection maeda.naoaki
2006-04-21 2:27 ` [RFC][PATCH 3/9] CPU controller - Adds timeslice scaling maeda.naoaki
2006-04-21 8:17 ` Mike Galbraith
2006-04-21 8:56 ` MAEDA Naoaki
2006-04-21 11:50 ` [ckrm-tech] " Naoaki MAEDA
2006-04-21 12:03 ` Mike Galbraith
2006-04-21 11:53 ` Mike Galbraith
2006-04-21 2:27 ` [RFC][PATCH 4/9] CPU controller - Adds interface functions maeda.naoaki
2006-04-21 2:27 ` [RFC][PATCH 5/9] CPU controller - Documents how the controller works maeda.naoaki
2006-04-23 7:13 ` Mike Galbraith [this message]
2006-04-24 6:25 ` [ckrm-tech] " MAEDA Naoaki
2006-04-24 9:49 ` Mike Galbraith
2006-04-21 2:27 ` [RFC][PATCH 6/9] CPU controller - Adds basic functions and registering the controller maeda.naoaki
2006-04-21 2:28 ` [RFC][PATCH 7/9] CPU controller - Adds routines to change share values and show stat maeda.naoaki
2006-04-21 2:28 ` [RFC][PATCH 8/9] CPU controller - Adds cpu hotplug notifier maeda.naoaki
2006-04-21 2:28 ` [RFC][PATCH 9/9] CPU controller - Documents how to use the controller maeda.naoaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145776430.7990.58.camel@homer \
--to=efault@gmx.de \
--cc=ckrm-tech@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=maeda.naoaki@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.