From: Greg Smith <gsmith@nc.rr.com>
To: linux-kernel@vger.kernel.org
Cc: schwidefsky@de.ibm.com, pavlic@de.ibm.com
Subject: s390 lcs incorrect test
Date: Wed, 26 Apr 2006 20:05:30 -0400 [thread overview]
Message-ID: <1146096330.3012.58.camel@localhost.localdomain> (raw)
While debugging why our LCS emulator is having some problems I noticed
the following weirdness in drivers/s390/net/lcs.c routine lcs_irq:
--- lcs.c.orig 2006-04-24 16:20:24.000000000 -0400
+++ lcs.c 2006-04-26 19:56:45.000000000 -0400
@@ -1354,7 +1354,7 @@
index = (struct ccw1 *) __va((addr_t) irb->scsw.cpa)
- channel->ccws;
if ((irb->scsw.actl & SCSW_ACTL_SUSPENDED) ||
- (irb->scsw.cstat | SCHN_STAT_PCI))
+ (irb->scsw.cstat & SCHN_STAT_PCI))
/* Bloody io subsystem tells us lies about cpa... */
index = (index - 1) & (LCS_NUM_BUFFS - 1);
while (channel->io_idx != index) {
The `if' statement is always true since SCHN_STAT_PCI is defined as
0x80. Don't know if this has anything to do with our LCS problems but
thought I would pass it on.
Greg Smith
next reply other threads:[~2006-04-27 0:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 0:05 Greg Smith [this message]
2006-04-27 4:34 ` s390 lcs incorrect test Frank Pavlic
2006-04-28 5:12 ` Greg Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1146096330.3012.58.camel@localhost.localdomain \
--to=gsmith@nc.rr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavlic@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.