From: Dan Williams <dcbw@redhat.com>
To: Ralf Baechle DL5RB <ralf@linux-mips.org>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-hams@vger.kernel.org
Subject: Re: [AX25, ROSE] Remove useless SET_MODULE_OWNER calls.
Date: Sun, 30 Apr 2006 08:03:26 -0400 [thread overview]
Message-ID: <1146398606.2252.1.camel@localhost.localdomain> (raw)
In-Reply-To: <20060429142943.GA4402@linux-mips.org>
On Sat, 2006-04-29 at 15:29 +0100, Ralf Baechle DL5RB wrote:
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
>
> --
>
> net/netrom/nr_dev.c | 1 -
> net/rose/rose_dev.c | 1 -
> 2 files changed, 2 deletions(-)
>
> Index: linux-net.git/net/netrom/nr_dev.c
> ===================================================================
> --- linux-net.git.orig/net/netrom/nr_dev.c 2006-04-29 01:43:47.000000000 +0100
> +++ linux-net.git/net/netrom/nr_dev.c 2006-04-29 11:38:00.000000000 +0100
> @@ -185,7 +185,6 @@ static struct net_device_stats *nr_get_s
>
> void nr_setup(struct net_device *dev)
> {
> - SET_MODULE_OWNER(dev);
> dev->mtu = NR_MAX_PACKET_SIZE;
> dev->hard_start_xmit = nr_xmit;
> dev->open = nr_open;
Are these done by anything else now? Did something change to make
SET_MODULE_OWNER useless in individual drivers? I'm asking because I
was fairly sure that SET_MODULE_OWNER set up some sysfs links and such
that HAL depends on to figure out information about the driver and
hardware device, much like SET_NETDEV_DEV.
Dan
next prev parent reply other threads:[~2006-04-30 12:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-29 14:29 [AX25, ROSE] Remove useless SET_MODULE_OWNER calls Ralf Baechle DL5RB
2006-04-30 12:03 ` Dan Williams [this message]
2006-04-30 13:38 ` Herbert Xu
2006-04-30 13:38 ` Herbert Xu
2006-04-30 17:04 ` Dan Williams
2006-05-04 6:23 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1146398606.2252.1.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-hams@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.