From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] via-pmu: report powerbutton as proper input event
Date: Mon, 01 May 2006 19:09:26 +1000 [thread overview]
Message-ID: <1146474566.30710.45.camel@localhost.localdomain> (raw)
In-Reply-To: <1146473774.24172.2.camel@localhost>
On Mon, 2006-05-01 at 10:56 +0200, Johannes Berg wrote:
> On Mon, 2006-05-01 at 16:58 +1000, Benjamin Herrenschmidt wrote:
> > On Fri, 2006-04-28 at 21:15 +0200, Johannes Berg wrote:
> > > This patch adds an input device for the power button so that userspace gets
> > > notified about the user pressing it via the standard input layer.
> >
> > Looks interesting. Waht about other buttons/events the PMU can report ?
>
> What else does it report? As far as I know it doesn't have anything
> else, at least on my system.
Depends on the machine... earlier ones have the backlight there or
volume control.. then LID close could be an event too...
> > > +#define BUS_PMU 0x20
> >
> > Magic numbers... BAD BAD BAD ... Somebody needs to LART the input layer
> > people.
>
> It's not really a "magic" number since it doesn't really carry any
> information, or would you like string identifiers in each device
> descriptor? An enum would be just the same, in fact, the definition
> could be rewritten as an enum :)
>
> > Do we need these here ? Why not an initcall self-contained in each
> > file ?
>
> No heh, good point.
>
> Thanks,
> johannes
next prev parent reply other threads:[~2006-05-01 9:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-28 19:15 [PATCH] via-pmu: report powerbutton as proper input event Johannes Berg
2006-05-01 6:58 ` Benjamin Herrenschmidt
2006-05-01 8:56 ` Johannes Berg
2006-05-01 9:09 ` Benjamin Herrenschmidt [this message]
2006-05-01 9:21 ` Johannes Berg
2006-05-01 9:35 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1146474566.30710.45.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.