All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Butterworth <harry@hebutterworth.freeserve.co.uk>
To: Mark Williamson <mark.williamson@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com, sanjay kumar <sanjay.kushwaha@gmail.com>
Subject: Re: Re: usbback cleanup code
Date: Tue, 02 May 2006 13:50:51 +0100	[thread overview]
Message-ID: <1146574251.15264.6.camel@localhost.localdomain> (raw)
In-Reply-To: <200605021231.22993.mark.williamson@cl.cam.ac.uk>

On Tue, 2006-05-02 at 12:31 +0100, Mark Williamson wrote:
> I might be able to find time to look through the patch in more detail to see 
> what specifically I think needs doing.  If I gave more specific feedback, 
> would you be willing to take another pass?  Doing so ought to move us a step 
> forwards, at least.

If my team lead asks me to, I will do another pass.  Your feedback will
be useful in any case.

> I'd suggest that failing them all is fine for now, and then look at improving 
> it later.  I don't imagine it's going to be a common scenario, and would 
> suggest that we're better having an in-tree driver that can be improved as we 
> go.

The current driver was working well enough to go into the tree.  The
protocol issues are just a theoretical exposure, I hadn't actually seen
them occurring.

> 
> Cheers,
> Mark
> 

  reply	other threads:[~2006-05-02 12:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2717599f0603120920x74e317a4mf429f3229bbe90a9@mail.gmail.com>
     [not found] ` <1142245114.8822.6.camel@localhost.localdomain>
     [not found]   ` <2717599f0604030654i52a03ec8n83106b7d8b0d3b96@mail.gmail.com>
     [not found]     ` <1144076194.9237.45.camel@localhost.localdomain>
     [not found]       ` <2717599f0604291243y6123a4ccn27d826ea21d4663d@mail.gmail.com>
2006-05-01  4:43         ` usbback cleanup code Harry Butterworth
2006-05-01 14:04           ` M.A. Williamson
2006-05-01 18:59             ` Harry Butterworth
2006-05-01 19:32               ` Mark Williamson
2006-05-01 20:56                 ` Anthony Liguori
2006-05-01 21:10                   ` Mark Williamson
2006-05-01 23:41                     ` Anthony Liguori
2006-05-02  9:59                 ` Harry Butterworth
2006-05-02 11:31                   ` Mark Williamson
2006-05-02 12:50                     ` Harry Butterworth [this message]
2006-05-02 15:38                     ` Harry Butterworth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1146574251.15264.6.camel@localhost.localdomain \
    --to=harry@hebutterworth.freeserve.co.uk \
    --cc=mark.williamson@cl.cam.ac.uk \
    --cc=sanjay.kushwaha@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.