From: Wei Yongjun <weiyj@soft.fujitsu.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: weiyj@soft.fujitsu.com, netdev@vger.kernel.org
Subject: Re: [PATCH]ip_options_fragment() has no effect on fragmentation
Date: Fri, 05 May 2006 20:36:14 -0400 [thread overview]
Message-ID: <1146875774.3659.22.camel@LINE> (raw)
I had tested the patch under linux system, maybe this mail is correct.
Fix error point to options in ip_options_fragment(). optptr get a error
pointer to the ipv4 header, correct is pointer to ipv4 options.
Signed-off-by: Wei Yongjun <weiyj@soft.fujitsu.com>
--- a/net/ipv4/ip_options.c 2006-01-27 09:14:33.463612696 +0900
+++ b/net/ipv4/ip_options.c 2006-01-27 09:12:21.857619848 +0900
@@ -207,7 +207,7 @@
void ip_options_fragment(struct sk_buff * skb)
{
- unsigned char * optptr = skb->nh.raw;
+ unsigned char * optptr = skb->nh.raw + sizeof(struct iphdr);
struct ip_options * opt = &(IPCB(skb)->opt);
int l = opt->optlen;
int optlen;
On Monday 08 May 2006 01:41, David S. Miller wrote:
> Actually it didn't get applied for some reason.
>
> Please resubmit it properly with a full changelog and
> "Signed-off-by: " lines, and make double sure that your
> email client does not corrupt the patch so that I may
> apply it cleanly. Test this by sending it to yourself
> and trying to apply the patch.
next reply other threads:[~2006-05-08 7:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-06 0:36 Wei Yongjun [this message]
2006-05-09 22:20 ` [PATCH]ip_options_fragment() has no effect on fragmentation David S. Miller
[not found] <001701c6277a$eaa93950$cfa0220a@WeiYJ>
[not found] ` <1138821701.3852.8.camel@L-tech1>
[not found] ` <20060202.170840.114568749.davem@davemloft.net>
2006-05-05 17:50 ` weiyj
2006-05-08 5:39 ` David S. Miller
2006-05-08 5:41 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2006-01-26 17:02 Wei Yongjun
2006-01-26 5:59 ` Eric Dumazet
2006-01-26 8:46 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1146875774.3659.22.camel@LINE \
--to=weiyj@soft.fujitsu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.