From: Marcel Holtmann <marcel@holtmann.org>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: fix potential NULL ptr deref in dtl1_cs.c::dtl1_hci_send_frame()
Date: Sun, 07 May 2006 21:21:16 +0200 [thread overview]
Message-ID: <1147029676.11328.5.camel@localhost> (raw)
In-Reply-To: <200605072050.57415.jesper.juhl@gmail.com>
Hi Jesper,
> There's a problem in drivers/bluetooth/dtl1_cs.c::dtl1_hci_send_frame()
>
> If bt_skb_alloc() returns NULL, then skb_reserve(s, NSHL); will cause a
> NULL pointer deref - ouch.
> If we can't allocate the resources we require we need to tell the caller
> by returning -ENOMEM.
>
> Found by the coverity checker as bug #409
>
> Patch is compile tested, but that's all, due to lack of hardware.
>
>
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
prev parent reply other threads:[~2006-05-07 19:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-07 18:50 [PATCH] Bluetooth: fix potential NULL ptr deref in dtl1_cs.c::dtl1_hci_send_frame() Jesper Juhl
2006-05-07 19:21 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147029676.11328.5.camel@localhost \
--to=marcel@holtmann.org \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.