All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Daniel Walker <dwalker@mvista.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] BusLogic gcc 4.1 warning fixes
Date: Wed, 10 May 2006 11:44:35 +0100	[thread overview]
Message-ID: <1147257875.17886.15.camel@localhost.localdomain> (raw)
In-Reply-To: <200605100255.k4A2tuuf031655@dwalker1.mvista.com>

On Maw, 2006-05-09 at 19:55 -0700, Daniel Walker wrote:
> I just commented out BusLogic_AbortCommand because the code that uses it is 
> commented out the same way .. It could just be removed .

Adds another leak in the failure case.
Agree about the AbortCommand function.


  parent reply	other threads:[~2006-05-10 10:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-10  2:55 [PATCH -mm] BusLogic gcc 4.1 warning fixes Daniel Walker
2006-05-10  8:26 ` Christoph Hellwig
2006-05-10 10:44 ` Alan Cox [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-05-10 17:28 Daniel Walker
2006-05-11 17:12 ` Andrew Morton
2006-05-11 20:30 Daniel Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1147257875.17886.15.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@osdl.org \
    --cc=dwalker@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.