From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: Re: [PATCH/rfc] schedule /sys/device/.../power for removal Date: Sun, 14 May 2006 10:13:51 +1000 Message-ID: <1147565632.21291.15.camel@localhost.localdomain> References: <20060512100544.GA29010@elf.ucw.cz> <20060512031151.76a9d226.akpm@osdl.org> <200605120652.55658.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============88475461671005973==" Return-path: In-Reply-To: <200605120652.55658.david-b@pacbell.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.osdl.org Errors-To: linux-pm-bounces@lists.osdl.org To: David Brownell Cc: Andrew Morton , linux-pm@lists.osdl.org, linux-kernel@vger.kernel.org, Pavel Machek List-Id: linux-pm@vger.kernel.org --===============88475461671005973== Content-Type: text/plain Content-Transfer-Encoding: 7bit On Fri, 2006-05-12 at 06:52 -0700, David Brownell wrote: > On Friday 12 May 2006 3:11 am, Andrew Morton wrote: > > > > What will be impacted by this? > > Driver suspend/resume testing ... impact is strongly negative. > > Without this interface, there is NO way to test individual drivers for > correct handling of suspend/resume calls; the only way to test drivers > is to suspend/resume the whole system, along with all other drivers in > the system. Which means that ALL the drivers must work sanely before > tests for any one of them can succeed ... a losing model when you're > testing PM on new platforms. > > Which IMO makes removing this a Bad Thing. It needs to have some > kind of replacement in place before the "magic numbers" go away. And that's why Pavel is not proposing to remove it right away... but to schedule it's removal so that developpers know right now that building a whole new kernel<->user interface based on that is not the smartest thing to do. > (The magic numbers are bad, and should go away -- yes. Nobody has > really shown that userspace needs this mechanism for any purpose > other than driver testing. Userspace device-specific power management > tools would need knowledge that's not yet exposed though sysfs.) > > I think both Patrick Mochel and Alan Stern have sent patches at > various times to let individual drivers provide a list of named > states they support, In some cases (like PCI) those lists could > be delegated to bus-specific code. > > _______________________________________________ > linux-pm mailing list > linux-pm@lists.osdl.org > https://lists.osdl.org/mailman/listinfo/linux-pm --===============88475461671005973== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline --===============88475461671005973==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964816AbWENAOs (ORCPT ); Sat, 13 May 2006 20:14:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964821AbWENAOs (ORCPT ); Sat, 13 May 2006 20:14:48 -0400 Received: from gate.crashing.org ([63.228.1.57]:28839 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S964816AbWENAOs (ORCPT ); Sat, 13 May 2006 20:14:48 -0400 Subject: Re: [linux-pm] Re: [PATCH/rfc] schedule /sys/device/.../power for removal From: Benjamin Herrenschmidt To: David Brownell Cc: linux-pm@lists.osdl.org, Andrew Morton , linux-kernel@vger.kernel.org, Pavel Machek In-Reply-To: <200605120652.55658.david-b@pacbell.net> References: <20060512100544.GA29010@elf.ucw.cz> <20060512031151.76a9d226.akpm@osdl.org> <200605120652.55658.david-b@pacbell.net> Content-Type: text/plain Date: Sun, 14 May 2006 10:13:51 +1000 Message-Id: <1147565632.21291.15.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2006-05-12 at 06:52 -0700, David Brownell wrote: > On Friday 12 May 2006 3:11 am, Andrew Morton wrote: > > > > What will be impacted by this? > > Driver suspend/resume testing ... impact is strongly negative. > > Without this interface, there is NO way to test individual drivers for > correct handling of suspend/resume calls; the only way to test drivers > is to suspend/resume the whole system, along with all other drivers in > the system. Which means that ALL the drivers must work sanely before > tests for any one of them can succeed ... a losing model when you're > testing PM on new platforms. > > Which IMO makes removing this a Bad Thing. It needs to have some > kind of replacement in place before the "magic numbers" go away. And that's why Pavel is not proposing to remove it right away... but to schedule it's removal so that developpers know right now that building a whole new kernel<->user interface based on that is not the smartest thing to do. > (The magic numbers are bad, and should go away -- yes. Nobody has > really shown that userspace needs this mechanism for any purpose > other than driver testing. Userspace device-specific power management > tools would need knowledge that's not yet exposed though sysfs.) > > I think both Patrick Mochel and Alan Stern have sent patches at > various times to let individual drivers provide a list of named > states they support, In some cases (like PCI) those lists could > be delegated to bus-specific code. > > _______________________________________________ > linux-pm mailing list > linux-pm@lists.osdl.org > https://lists.osdl.org/mailman/listinfo/linux-pm