From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Kevin Radloff <radsaq@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Updated libata PATA patch
Date: Mon, 15 May 2006 23:08:49 +0100 [thread overview]
Message-ID: <1147730929.26686.168.camel@localhost.localdomain> (raw)
In-Reply-To: <3b0ffc1f0605100939r607ef30dya743a7f1a1dbe03f@mail.gmail.com>
On Mer, 2006-05-10 at 12:39 -0400, Kevin Radloff wrote:
> > I'll do some more digging, but putting printks into ata_qc_issue_prot to
> > see where it explodes is the next step I suspect.
>
> Ah, I see.. I'll be waiting. :)
Much scratching of heads and tracing later it looks like a libata-core
bug rather than pata_pcmcia. Glad this blew up as its a nasty little bug
if I follow it right
Anyway try this patch as well
--- drivers/scsi/libata-core.c~ 2006-05-15 22:38:21.282153688 +0100
+++ drivers/scsi/libata-core.c 2006-05-15 22:38:21.283153536 +0100
@@ -1853,7 +1853,8 @@
goto err_out;
/* step 3: set host DMA timings */
- ata_host_set_dma(ap);
+ if(dev->dma_mode)
+ ata_host_set_dma(ap);
/* step 4: update devices' xfer mode */
for (i = 0; i < ATA_MAX_DEVICES; i++) {
next prev parent reply other threads:[~2006-05-15 21:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-09 17:44 Updated libata PATA patch Alan Cox
2006-05-10 1:48 ` Kevin Radloff
2006-05-10 14:09 ` Alan Cox
2006-05-10 16:05 ` Kevin Radloff
2006-05-10 16:39 ` Alan Cox
2006-05-10 16:39 ` Kevin Radloff
2006-05-15 22:08 ` Alan Cox [this message]
2006-05-15 23:13 ` Alan Cox
2006-05-12 2:34 ` John Stoffel
2006-05-15 2:46 ` John Stoffel
2006-05-11 19:06 ` Matthieu CASTET
2006-05-12 23:04 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147730929.26686.168.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=radsaq@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.