All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <haveblue@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Nishanth Aravamudan <nacc@us.ibm.com>,
	linux-kernel@vger.kernel.org,
	Yasunori Goto <y-goto@jp.fujitsu.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] typo in i386/init.c [BugMe #6538]
Date: Tue, 16 May 2006 10:34:15 -0700	[thread overview]
Message-ID: <1147800855.6623.111.camel@localhost.localdomain> (raw)
In-Reply-To: <20060516102427.2c50d469.akpm@osdl.org>

On Tue, 2006-05-16 at 10:24 -0700, Andrew Morton wrote:
> And partly because, well, just look at the patch.  It will give the kernel
> new global symbols add_memory() and remove_memory().  So how come it links
> OK at present?

It links OK now with normal configurations, because nobody references
add/remove_memory() unless MEMORY_HOTPLUG is enabled.  The user in the
bug report

	http://bugme.osdl.org/show_bug.cgi?id=6538

managed to enable sparsemem and memory hotplug.  The generic hotplug
code referenced those symbols, and they got a link error.

-- Dave


  reply	other threads:[~2006-05-16 17:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-16 16:50 [PATCH] typo in i386/init.c [BugMe #6538] Nishanth Aravamudan
2006-05-16 16:58 ` Dave Hansen
2006-05-16 17:24 ` Andrew Morton
2006-05-16 17:34   ` Dave Hansen [this message]
2006-05-16 17:34   ` Nishanth Aravamudan
2006-05-16 17:40     ` Dave Hansen
2006-05-17  5:37       ` KAMEZAWA Hiroyuki
  -- strict thread matches above, loose matches on Subject: below --
2006-05-13 15:49 Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1147800855.6623.111.camel@localhost.localdomain \
    --to=haveblue@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nacc@us.ibm.com \
    --cc=y-goto@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.