From: Pavel Roskin <proski@gnu.org>
To: Martin Langhoff <martin.langhoff@gmail.com>
Cc: Bertrand Jacquin <beber.mailing@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: cvsimport weird
Date: Thu, 18 May 2006 01:44:54 -0400 [thread overview]
Message-ID: <1147931094.32050.51.camel@dv> (raw)
In-Reply-To: <1147924771.32050.40.camel@dv>
On Wed, 2006-05-17 at 23:59 -0400, Pavel Roskin wrote:
> I'm quite sure that it's a bug in cvsps. It displays such things on
> x86_64, but works properly on 32-bit PowerPC.
Address resolution is broken in cvsps on 64-bit machines. This patch to
cvsps is needed:
--- cbtcommon/tcpsocket.c
+++ cbtcommon/tcpsocket.c
@@ -198,7 +198,7 @@ convert_address(long *dest, const char *
memcpy(dest, &ip.s_addr, sizeof(ip.s_addr));
}
#else
- if ( (*dest = inet_addr(addr_str)) != -1)
+ if ( (*dest = inet_addr(addr_str)) != INADDR_NONE)
{
/* nothing */
}
However, it's not sufficient to fix the original problem of empty CVS
server version string. For some reason cvsps fails to authenticate with
pserver. The ext protocol is working.
It's interesting that both git-cvsimport and cvsps have code to
authenticate over the pserver protocol. I think maybe git-cvsimport
shouldn't do it, or maybe it should close some sockets before running
cvsps.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2006-05-18 5:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-18 1:00 cvsimport weird Bertrand Jacquin
2006-05-18 2:54 ` Martin Langhoff
2006-05-18 3:59 ` Pavel Roskin
2006-05-18 5:44 ` Pavel Roskin [this message]
2006-05-18 5:56 ` YOSHIFUJI Hideaki / 吉藤英明
2006-05-18 9:33 ` Bertrand Jacquin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147931094.32050.51.camel@dv \
--to=proski@gnu.org \
--cc=beber.mailing@gmail.com \
--cc=git@vger.kernel.org \
--cc=martin.langhoff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.