From: Lee Revell <rlrevell@joe-job.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: mark.fasheh@oracle.com, kurt.hackel@oracle.com
Subject: Question re: __mlog_cpu_guess in fs/ocfs2/cluster/masklog.h
Date: Mon, 22 May 2006 19:45:06 -0400 [thread overview]
Message-ID: <1148341507.2556.104.camel@mindpipe> (raw)
I am puzzled by this code and comment:
/*
* smp_processor_id() "helpfully" screams when called outside preemptible
* regions in current kernels. sles doesn't have the variants that don't
* scream. just do this instead of trying to guess which we're building
* against.. *sigh*.
*/
#define __mlog_cpu_guess ({ \
unsigned long _cpu = get_cpu(); \
put_cpu(); \
_cpu; \
})
First I think you mean "inside preemptible regions". Second, it screams
because it's a bug to call smp_processor_id() from preemptible code!
Am I missing something?
Lee
next reply other threads:[~2006-05-22 23:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-22 23:45 Lee Revell [this message]
2006-05-23 15:27 ` Question re: __mlog_cpu_guess in fs/ocfs2/cluster/masklog.h Zach Brown
2006-05-23 16:34 ` Lee Revell
2006-05-23 16:42 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1148341507.2556.104.camel@mindpipe \
--to=rlrevell@joe-job.com \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.fasheh@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.