All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomas Racek <tracek@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: lczerner@redhat.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: Change fstrim behaviour to be consistent with upstream version
Date: Tue, 31 Jul 2012 06:24:26 -0400 (EDT)	[thread overview]
Message-ID: <1148424756.1249426.1343730266948.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20120730220413.GI2877@dastard>

> If we have duplicate code (i.e. a copy of the upstream utility) or
> the local tool can be completely replaced by the upstream tool,
> then we should use upstream and remove the local copy completely.
> Distros have been shipping fstrim for long enough now that most
> people running testing on upstream kernels will have it installed...
> 

OK, I'll create the patch which drops local version.

> Adding a _require_fstrim() function that checks for the upstream
> version of fstrim to be installed for each test that requires it
> would go along with this.

Did you mean something like

_require_fstrim()
{
         which fstrim &>/dev/null || _notrun "This test requires fstrim utility."
}

in common.rc or locally in each test?

Thanks for comments!

Tomas

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2012-07-31 10:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-30 12:06 [PATCH] xfstests: Change fstrim behaviour to be consistent with upstream version Tomas Racek
2012-07-30 22:04 ` Dave Chinner
2012-07-31  2:33   ` Christoph Hellwig
2012-07-31 12:01     ` Lukáš Czerner
2012-07-31 10:24   ` Tomas Racek [this message]
2012-07-31 12:15     ` Lukáš Czerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1148424756.1249426.1343730266948.JavaMail.root@redhat.com \
    --to=tracek@redhat.com \
    --cc=david@fromorbit.com \
    --cc=lczerner@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.