All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>,
	Eric Wong <normalperson@yhbt.net>
Subject: [PATCH 4/4] t6000lib: workaround a possible dash bug
Date: Thu, 25 May 2006 19:06:18 -0700	[thread overview]
Message-ID: <11486091792604-git-send-email-normalperson@yhbt.net> (raw)
In-Reply-To: <11486091793385-git-send-email-normalperson@yhbt.net>

pdksh doesn't need this patch, of course bash works fine since
that what most users use.

Normally, 'var=val command' seems to work fine with dash, but
perhaps there's something weird going on with "$@".  dash is
pretty widespread, so it'll be good to support this even though
it does seem like a bug in dash.

Signed-off-by: Eric Wong <normalperson@yhbt.net>

---

 t/t6000lib.sh |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

cba907ce0b1c0927fb15cbb5dd91a4129ff9a950
diff --git a/t/t6000lib.sh b/t/t6000lib.sh
index c6752af..d402621 100755
--- a/t/t6000lib.sh
+++ b/t/t6000lib.sh
@@ -69,7 +69,9 @@ on_committer_date()
 {
     _date=$1
     shift 1
-    GIT_COMMITTER_DATE=$_date "$@"
+    export GIT_COMMITTER_DATE="$_date"
+    "$@"
+    unset GIT_COMMITTER_DATE
 }
 
 # Execute a command and suppress any error output.
-- 
1.3.2.g7d11

  reply	other threads:[~2006-05-26  2:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-26  2:06 [PATCH 0/4] fix tests so they run without needing bash Eric Wong
2006-05-26  2:06 ` [PATCH 1/4] t3300-funny-names: shell portability fixes Eric Wong
2006-05-26  2:06   ` [PATCH 2/4] tests: Remove heredoc usage inside quotes Eric Wong
2006-05-26  2:06     ` [PATCH 3/4] t5500-fetch-pack: remove local (bashism) usage Eric Wong
2006-05-26  2:06       ` Eric Wong [this message]
2006-05-26 12:33         ` [PATCH 4/4] t6000lib: workaround a possible dash bug Herbert Xu
2007-09-21 13:28         ` Herbert Xu
2007-09-21 20:45           ` Eric Wong
2007-09-26  8:41             ` Herbert Xu
2006-05-26 12:23       ` [PATCH 3/4] t5500-fetch-pack: remove local (bashism) usage Herbert Xu
2006-05-29  5:28         ` Eric Wong
2006-05-29  5:36           ` Junio C Hamano
2006-05-29  7:31           ` Herbert Xu
2006-05-26 12:22     ` [PATCH 2/4] tests: Remove heredoc usage inside quotes Herbert Xu
2006-05-29  5:30       ` Eric Wong
2006-05-26  3:01 ` [PATCH 0/4] fix tests so they run without needing bash Junio C Hamano
2006-05-29  5:39   ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11486091792604-git-send-email-normalperson@yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=git@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.