From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1FlBYX-0004pL-Bs for mharc-grub-devel@gnu.org; Tue, 30 May 2006 17:15:13 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FlBYW-0004pF-Sh for grub-devel@gnu.org; Tue, 30 May 2006 17:15:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FlBYT-0004oe-IF for grub-devel@gnu.org; Tue, 30 May 2006 17:15:11 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FlBYT-0004ob-Ee for grub-devel@gnu.org; Tue, 30 May 2006 17:15:09 -0400 Received: from [66.111.4.27] (helo=out3.smtp.messagingengine.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FlBeL-0006Tq-MU for grub-devel@gnu.org; Tue, 30 May 2006 17:21:13 -0400 Received: from frontend3.internal (frontend3.internal [10.202.2.152]) by frontend1.messagingengine.com (Postfix) with ESMTP id 90A55D68D2C for ; Tue, 30 May 2006 17:15:05 -0400 (EDT) Received: from heartbeat2.messagingengine.com ([10.202.2.161]) by frontend3.internal (MEProxy); Tue, 30 May 2006 17:15:06 -0400 X-Sasl-enc: 482NkOgQDn/vI+YYwd/wgPPW39uZEQbCfYZXtLM3Yylu 1149023706 Received: from basalt-009053041185.austin.ibm.com (pixpat.austin.ibm.com [192.35.232.241]) by mail.messagingengine.com (Postfix) with ESMTP id 27882102A for ; Tue, 30 May 2006 17:15:05 -0400 (EDT) From: Hollis Blanchard To: The development of GRUB 2 In-Reply-To: <447CB449.9080901@nic.fi> References: <447CB449.9080901@nic.fi> Content-Type: text/plain; charset=utf-8 Date: Tue, 30 May 2006 16:15:51 -0500 Message-Id: <1149023752.7177.86.camel@basalt.austin.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 (2.6.1-1.fc5.2) Content-Transfer-Encoding: quoted-printable Subject: Re: [patch] Fix for building correct code on i386-pc (CVS-HEAD) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 21:15:13 -0000 On Wed, 2006-05-31 at 00:08 +0300, Vesa J=C3=A4=C3=A4skel=C3=A4inen wrote= : > Attached patch fixes problems for compiling correct code on i386-pc... > other platforms needs to be modified similarly too... I'm confused by this; could you explain? If _TARGET_CFLAGS is used for everything to be run on the target, perhaps we should just rename _CFLAGS to _TARGET_CFLAGS. Also, in the future, could you please supply best-guess code for other architectures? It's ok if you don't know, but in this case it seems it would be easy enough to duplicate your i386-pc.mk changes for the other .mk files. > Index: conf/common.rmk > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /sources/grub/grub2/conf/common.rmk,v > retrieving revision 1.7 > diff -u -r1.7 common.rmk > --- conf/common.rmk 27 May 2006 21:09:25 -0000 1.7 > +++ conf/common.rmk 30 May 2006 21:00:02 -0000 > @@ -27,61 +27,73 @@ > # For fshelp.mod. > fshelp_mod_SOURCES =3D fs/fshelp.c > fshelp_mod_CFLAGS =3D $(COMMON_CFLAGS) > +fshelp_mod_TARGET_CFLAGS =3D $(COMMON_TARGET_CFLAGS) > fshelp_mod_LDFLAGS =3D $(COMMON_LDFLAGS) ... > --- conf/i386-pc.rmk 28 May 2006 23:01:43 -0000 1.65 > +++ conf/i386-pc.rmk 30 May 2006 21:00:02 -0000 > @@ -2,6 +2,7 @@ > =20 > COMMON_ASFLAGS =3D -nostdinc -fno-builtin > COMMON_CFLAGS =3D -fno-builtin -mrtd -mregparm=3D3 -m32 > +COMMON_TARGET_CFLAGS =3D -fno-builtin -mrtd -mregparm=3D3 -m32 > COMMON_LDFLAGS =3D -melf_i386 -nostdlib