From: Tejun Heo <htejun@gmail.com>
To: Jens Axboe <axboe@suse.de>,
James Bottomley <James.Bottomley@SteelEye.com>,
Dave Miller <davem@redhat.com>,
bzolnier@gmail.com, james.steward@dynamicratings.com,
jgarzik@pobox.com, mattjreimer@gmail.com,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
rmk@arm.linux.org.uk, lkml <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: Tejun Heo <htejun@gmail.com>
Subject: [PATCH 5/5] md: add cpu cache flushes after kmapping and modifying a page
Date: Sun, 4 Jun 2006 12:41:20 +0900 [thread overview]
Message-ID: <11493924803060-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: <1149392479501-git-send-email-htejun@gmail.com>
Add calls to flush_kernel_dcache_page() after CPU has kmapped and
modified a page. This fixes PIO cache coherency bugs on architectures
with aliased caches.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/md/raid1.c | 1 +
drivers/md/raid5.c | 6 ++++--
drivers/md/raid6main.c | 6 ++++--
3 files changed, 9 insertions(+), 4 deletions(-)
716500bdf7de6acb87e36c8146d83dd3c429bc82
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 4070eff..30ca7cf 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -720,6 +720,7 @@ static struct page **alloc_behind_pages(
goto do_sync_io;
memcpy(kmap(pages[i]) + bvec->bv_offset,
kmap(bvec->bv_page) + bvec->bv_offset, bvec->bv_len);
+ flush_kernel_dcache_page(pages[i]);
kunmap(pages[i]);
kunmap(bvec->bv_page);
}
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 3184360..3adb64f 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -813,10 +813,12 @@ static void copy_data(int frombio, struc
if (clen > 0) {
char *ba = __bio_kmap_atomic(bio, i, KM_USER0);
- if (frombio)
+ if (frombio) {
memcpy(pa+page_offset, ba+b_offset, clen);
- else
+ } else {
memcpy(ba+b_offset, pa+page_offset, clen);
+ flush_kernel_dcache_page(kmap_atomic_to_page(ba));
+ }
__bio_kunmap_atomic(ba, KM_USER0);
}
if (clen < len) /* hit end of page */
diff --git a/drivers/md/raid6main.c b/drivers/md/raid6main.c
index bc69355..b9700bd 100644
--- a/drivers/md/raid6main.c
+++ b/drivers/md/raid6main.c
@@ -727,10 +727,12 @@ static void copy_data(int frombio, struc
if (clen > 0) {
char *ba = __bio_kmap_atomic(bio, i, KM_USER0);
- if (frombio)
+ if (frombio) {
memcpy(pa+page_offset, ba+b_offset, clen);
- else
+ } else {
memcpy(ba+b_offset, pa+page_offset, clen);
+ flush_kernel_dcache_page(kmap_atomic_to_page(ba));
+ }
__bio_kunmap_atomic(ba, KM_USER0);
}
if (clen < len) /* hit end of page */
--
1.3.2
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <htejun@gmail.com>
To: Jens Axboe <axboe@suse.de>,
James Bottomley <James.Bottomley@SteelEye.com>,
Dave Miller <davem@redhat.com>,
bzolnier@gmail.com, james.steward@dynamicratings.com,
jgarzik@pobox.com, mattjreimer@gmail.com,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
rmk@arm.linux.org.uk, lkml <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
htejun@gmail.com
Cc: Tejun Heo <htejun@gmail.com>
Subject: [PATCH 5/5] md: add cpu cache flushes after kmapping and modifying a page
Date: Sun, 4 Jun 2006 12:41:20 +0900 [thread overview]
Message-ID: <11493924803060-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: <1149392479501-git-send-email-htejun@gmail.com>
Add calls to flush_kernel_dcache_page() after CPU has kmapped and
modified a page. This fixes PIO cache coherency bugs on architectures
with aliased caches.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/md/raid1.c | 1 +
drivers/md/raid5.c | 6 ++++--
drivers/md/raid6main.c | 6 ++++--
3 files changed, 9 insertions(+), 4 deletions(-)
716500bdf7de6acb87e36c8146d83dd3c429bc82
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 4070eff..30ca7cf 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -720,6 +720,7 @@ static struct page **alloc_behind_pages(
goto do_sync_io;
memcpy(kmap(pages[i]) + bvec->bv_offset,
kmap(bvec->bv_page) + bvec->bv_offset, bvec->bv_len);
+ flush_kernel_dcache_page(pages[i]);
kunmap(pages[i]);
kunmap(bvec->bv_page);
}
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 3184360..3adb64f 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -813,10 +813,12 @@ static void copy_data(int frombio, struc
if (clen > 0) {
char *ba = __bio_kmap_atomic(bio, i, KM_USER0);
- if (frombio)
+ if (frombio) {
memcpy(pa+page_offset, ba+b_offset, clen);
- else
+ } else {
memcpy(ba+b_offset, pa+page_offset, clen);
+ flush_kernel_dcache_page(kmap_atomic_to_page(ba));
+ }
__bio_kunmap_atomic(ba, KM_USER0);
}
if (clen < len) /* hit end of page */
diff --git a/drivers/md/raid6main.c b/drivers/md/raid6main.c
index bc69355..b9700bd 100644
--- a/drivers/md/raid6main.c
+++ b/drivers/md/raid6main.c
@@ -727,10 +727,12 @@ static void copy_data(int frombio, struc
if (clen > 0) {
char *ba = __bio_kmap_atomic(bio, i, KM_USER0);
- if (frombio)
+ if (frombio) {
memcpy(pa+page_offset, ba+b_offset, clen);
- else
+ } else {
memcpy(ba+b_offset, pa+page_offset, clen);
+ flush_kernel_dcache_page(kmap_atomic_to_page(ba));
+ }
__bio_kunmap_atomic(ba, KM_USER0);
}
if (clen < len) /* hit end of page */
--
1.3.2
next prev parent reply other threads:[~2006-06-04 3:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-04 3:41 [PATCHSET] block: fix PIO cache coherency bug, take 2 Tejun Heo
2006-06-04 3:41 ` [PATCH 1/5] arm: implement flush_kernel_dcache_page() Tejun Heo
2006-06-04 3:41 ` Tejun Heo
2006-06-04 3:49 ` [PATCH 1/5] (REPOST) " Tejun Heo
2006-06-04 6:45 ` [PATCH 1/5] " David Miller
2006-06-04 6:53 ` Tejun Heo
2006-06-04 7:04 ` David Miller
2006-06-04 3:41 ` [PATCH 2/5] ide: add cpu cache flushes after kmapping and modifying a page Tejun Heo
2006-06-04 3:41 ` Tejun Heo
2006-06-04 8:17 ` Christoph Hellwig
2006-06-04 9:09 ` Tejun Heo
2006-06-04 3:41 ` Tejun Heo [this message]
2006-06-04 3:41 ` [PATCH 5/5] md: " Tejun Heo
2006-06-04 3:41 ` [PATCH 4/5] SCSI: " Tejun Heo
2006-06-04 3:41 ` Tejun Heo
2006-06-04 8:20 ` Christoph Hellwig
2006-06-04 9:13 ` Tejun Heo
2006-06-04 20:24 ` Guennadi Liakhovetski
2006-06-04 3:41 ` [PATCH 3/5] libata: " Tejun Heo
2006-06-04 3:41 ` Tejun Heo
2006-06-04 20:44 ` [PATCHSET] block: fix PIO cache coherency bug, take 2 Russell King
2006-06-04 22:23 ` Russell King
2006-06-05 14:27 ` James Bottomley
2006-06-05 14:44 ` Russell King
2006-06-05 15:24 ` James Bottomley
2006-06-05 15:34 ` Russell King
2006-06-05 15:47 ` James Bottomley
2006-06-05 15:48 ` Russell King
2006-06-05 16:16 ` James Bottomley
2006-06-05 16:37 ` Russell King
2006-06-05 13:43 ` James Bottomley
2006-06-06 11:00 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11493924803060-git-send-email-htejun@gmail.com \
--to=htejun@gmail.com \
--cc=James.Bottomley@SteelEye.com \
--cc=axboe@suse.de \
--cc=bzolnier@gmail.com \
--cc=davem@redhat.com \
--cc=g.liakhovetski@gmx.de \
--cc=james.steward@dynamicratings.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mattjreimer@gmail.com \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.