All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@linutronix.de,
	torvalds@osdl.org
Subject: Re: [RFC][PATCH] request_irq(...,SA_BOOTMEM);
Date: Mon, 05 Jun 2006 17:48:10 +1000	[thread overview]
Message-ID: <1149493691.8543.57.camel@localhost.localdomain> (raw)
In-Reply-To: <20060605003127.fc1ea37a.akpm@osdl.org>


> I don't immediately see anything in there which would prevent us from
> running these:
> 
> 	vfs_caches_init_early();
> 	cpuset_init_early();
> 	mem_init();
> 	kmem_cache_init();
> 	setup_per_cpu_pageset();
> 
> just after sort_main_extable().
> 
> But things will explode ;)
> 
> I suggest you run up a patch, test it on whatever machines you have, send
> it over and I'll do the same.  But please make sure it has a config option
> to restore the old sequence for now.  a) So people can work out that it was
> this patch which broke things and b) so it doesn't adversely affect testing
> of other things too much.

Good ideas. I'll give these things a spin. One thing that may explode is
that all that code is running with local_irq_disable() (since local irqs
aren't enabled before init_IRQ()) and that means possible use of some
types of semaphores may trigger warn-on's (or worse as I think some
implementations of down_read() might even force-enable irqs).

But there is no fundamental reasons to do so ... that's the trick :) If
that happens, those semaphores are still ok as they should never get
into contention that early.

Anyway, I'll give it a spin on ppc and maybe x86 if I can find a victim
to test on here, and will send something.

Cheers,
Ben.



  reply	other threads:[~2006-06-05  7:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-05  5:40 [RFC][PATCH] request_irq(...,SA_BOOTMEM); Benjamin Herrenschmidt
2006-06-05  7:08 ` Benjamin Herrenschmidt
2006-06-05  7:31   ` Andrew Morton
2006-06-05  7:48     ` Benjamin Herrenschmidt [this message]
2006-06-05  8:24       ` Andrew Morton
2006-06-05  8:49         ` Benjamin Herrenschmidt
2006-06-05  8:57           ` Andrew Morton
2006-06-05  9:01         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1149493691.8543.57.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.