From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Adam Belay <abelay@novell.com>
Cc: Greg KH <greg@kroah.com>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 9/9] PCI PM: generic suspend/resume fixes
Date: Mon, 05 Jun 2006 19:45:58 +0100 [thread overview]
Message-ID: <1149533158.30554.36.camel@localhost.localdomain> (raw)
In-Reply-To: <1149529685.7831.177.camel@localhost.localdomain>
Ar Llu, 2006-06-05 am 13:48 -0400, ysgrifennodd Adam Belay:
> disabled before entering D3 (something that we fail to do before this
> patchset), and the vast majority of devices would end up in this state
> if we were using pci_set_power_state() in this function.
Only if that hardware supports D3 in the first place. That may be the
thing that is critical.
> With that in mind, any thoughts on giving this a little time in -mm and
> seeing how it fares? If any problems come up, we could revert to a more
> conservative approach.
It was a question not an objection. If the spec says it is right then it
has to be worth trying
Alan
next prev parent reply other threads:[~2006-06-05 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-05 8:46 [PATCH 9/9] PCI PM: generic suspend/resume fixes Adam Belay
2006-06-05 10:21 ` Alan Cox
2006-06-05 17:48 ` Adam Belay
2006-06-05 18:45 ` Alan Cox [this message]
2006-06-06 0:33 ` Benjamin Herrenschmidt
2006-06-07 3:13 ` Adam Belay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149533158.30554.36.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=abelay@novell.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.