From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian McMenamin Subject: Re: [linuxsh-dev] [PATCH] Add support for Yamaha AICA sound on SEGA Dreamcast Date: Thu, 08 Jun 2006 19:16:58 +0100 Message-ID: <1149790618.6041.2.camel@localhost.localdomain> References: <1149201071.9032.13.camel@localhost.localdomain> <1149334788.9065.5.camel@localhost.localdomain> <1149635448.5154.7.camel@localhost.localdomain> <1149704202.5087.6.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc-outsmtp1.homechoice.co.uk (sc-outsmtp1.homechoice.co.uk [81.1.65.35]) by alsa.jcu.cz (ALSA's E-mail Delivery System) with SMTP id 1D322176 for ; Thu, 8 Jun 2006 20:17:20 +0200 (MEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Takashi Iwai Cc: alsa-devel@alsa-project.org, Paul Mundt , Lee Revell , linux-kernel@vger.kernel.org, linux-sh List-Id: alsa-devel@alsa-project.org On Thu, 2006-06-08 at 12:35 +0200, Takashi Iwai wrote: > > It's uncoventional that a work struct is re-initialized on the fly. > > IMO, it's better to introduce a flag indicating the stream is already > running and use a single function/work struct. For example, Yes, I've did this sort of thing last night :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964867AbWFHSRS (ORCPT ); Thu, 8 Jun 2006 14:17:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964891AbWFHSRS (ORCPT ); Thu, 8 Jun 2006 14:17:18 -0400 Received: from sc-outsmtp1.homechoice.co.uk ([81.1.65.35]:10501 "HELO sc-outsmtp1.homechoice.co.uk") by vger.kernel.org with SMTP id S964867AbWFHSRR (ORCPT ); Thu, 8 Jun 2006 14:17:17 -0400 Subject: Re: [linuxsh-dev] [Alsa-devel] [PATCH] Add support for Yamaha AICA sound on SEGA Dreamcast From: Adrian McMenamin To: Takashi Iwai Cc: alsa-devel@alsa-project.org, Paul Mundt , Lee Revell , linux-kernel@vger.kernel.org, linux-sh In-Reply-To: References: <1149201071.9032.13.camel@localhost.localdomain> <1149334788.9065.5.camel@localhost.localdomain> <1149635448.5154.7.camel@localhost.localdomain> <1149704202.5087.6.camel@localhost.localdomain> Content-Type: text/plain Date: Thu, 08 Jun 2006 19:16:58 +0100 Message-Id: <1149790618.6041.2.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2006-06-08 at 12:35 +0200, Takashi Iwai wrote: > > It's uncoventional that a work struct is re-initialized on the fly. > > IMO, it's better to introduce a flag indicating the stream is already > running and use a single function/work struct. For example, Yes, I've did this sort of thing last night :)