All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Andrew Morton <akpm@osdl.org>
Cc: Christoph Lameter <clameter@sgi.com>,
	linux-kernel@vger.kernel.org, hugh@veritas.com,
	nickpiggin@yahoo.com.au, linux-mm@kvack.org, ak@suse.de,
	marcelo.tosatti@cyclades.com
Subject: Re: [PATCH 01/14] Per zone counter functionality
Date: Fri, 09 Jun 2006 11:22:13 +0200	[thread overview]
Message-ID: <1149844934.20886.41.camel@lappy> (raw)
In-Reply-To: <20060608210045.62129826.akpm@osdl.org>

On Thu, 2006-06-08 at 21:00 -0700, Andrew Morton wrote:
> On Thu, 8 Jun 2006 16:02:44 -0700 (PDT)
> Christoph Lameter <clameter@sgi.com> wrote:

> > +#ifdef CONFIG_SMP
> > +void refresh_cpu_vm_stats(int);
> > +void refresh_vm_stats(void);
> > +#else
> > +static inline void refresh_cpu_vm_stats(int cpu) { };
> > +static inline void refresh_vm_stats(void) { };
> > +#endif
> 
> do {} while (0), please.  Always.  All other forms (afaik) have problems. 
> In this case,
> 
> 	if (something)
> 		refresh_vm_stats();
> 	else
> 		foo();
> 
> will not compile.

It surely will, 'static inline' does not make it less of a function.
Although the trailing ; is not needed in the function definition.


WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Andrew Morton <akpm@osdl.org>
Cc: Christoph Lameter <clameter@sgi.com>,
	linux-kernel@vger.kernel.org, hugh@veritas.com,
	nickpiggin@yahoo.com.au, linux-mm@kvack.org, ak@suse.de,
	marcelo.tosatti@cyclades.com
Subject: Re: [PATCH 01/14] Per zone counter functionality
Date: Fri, 09 Jun 2006 11:22:13 +0200	[thread overview]
Message-ID: <1149844934.20886.41.camel@lappy> (raw)
In-Reply-To: <20060608210045.62129826.akpm@osdl.org>

On Thu, 2006-06-08 at 21:00 -0700, Andrew Morton wrote:
> On Thu, 8 Jun 2006 16:02:44 -0700 (PDT)
> Christoph Lameter <clameter@sgi.com> wrote:

> > +#ifdef CONFIG_SMP
> > +void refresh_cpu_vm_stats(int);
> > +void refresh_vm_stats(void);
> > +#else
> > +static inline void refresh_cpu_vm_stats(int cpu) { };
> > +static inline void refresh_vm_stats(void) { };
> > +#endif
> 
> do {} while (0), please.  Always.  All other forms (afaik) have problems. 
> In this case,
> 
> 	if (something)
> 		refresh_vm_stats();
> 	else
> 		foo();
> 
> will not compile.

It surely will, 'static inline' does not make it less of a function.
Although the trailing ; is not needed in the function definition.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2006-06-09  9:22 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-08 23:02 [PATCH 00/14] Zoned VM counters V2 Christoph Lameter
2006-06-08 23:02 ` Christoph Lameter
2006-06-08 23:02 ` [PATCH 01/14] Per zone counter functionality Christoph Lameter
2006-06-08 23:02   ` Christoph Lameter
2006-06-09  4:00   ` Andrew Morton
2006-06-09  4:00     ` Andrew Morton
2006-06-09  4:38     ` Andi Kleen
2006-06-09  4:38       ` Andi Kleen
2006-06-09  9:22     ` Peter Zijlstra [this message]
2006-06-09  9:22       ` Peter Zijlstra
2006-06-09  9:29       ` Andrew Morton
2006-06-09  9:29         ` Andrew Morton
2006-06-09 18:19       ` Horst von Brand
2006-06-09 18:19         ` Horst von Brand
2006-06-09 15:54     ` Christoph Lameter
2006-06-09 15:54       ` Christoph Lameter
2006-06-09 17:06       ` Andrew Morton
2006-06-09 17:06         ` Andrew Morton
2006-06-09 17:18         ` Christoph Lameter
2006-06-09 17:18           ` Christoph Lameter
2006-06-09 17:38           ` Andrew Morton
2006-06-09 17:38             ` Andrew Morton
2006-06-09  4:28   ` Andi Kleen
2006-06-09  4:28     ` Andi Kleen
2006-06-09 16:00     ` Christoph Lameter
2006-06-09 16:00       ` Christoph Lameter
2006-06-08 23:02 ` [PATCH 02/14] Include per zone counters in /proc/vmstat Christoph Lameter
2006-06-08 23:02   ` Christoph Lameter
2006-06-08 23:02 ` [PATCH 03/14] Conversion of nr_mapped to per zone counter Christoph Lameter
2006-06-08 23:02   ` Christoph Lameter
2006-06-08 23:03 ` [PATCH 04/14] Conversion of nr_pagecache " Christoph Lameter
2006-06-08 23:03   ` Christoph Lameter
2006-06-08 23:03 ` [PATCH 04/14] Use per zone counters to remove zone_reclaim_interval Christoph Lameter
2006-06-08 23:03   ` Christoph Lameter
2006-06-09  4:00   ` Andrew Morton
2006-06-09  4:00     ` Andrew Morton
2006-06-09 18:54     ` zoned VM stats: Add NR_ANON Christoph Lameter
2006-06-09 18:54       ` Christoph Lameter
2006-06-10  4:32       ` KAMEZAWA Hiroyuki
2006-06-10  4:32         ` KAMEZAWA Hiroyuki
2006-06-10  4:52         ` Christoph Lameter
2006-06-10  4:52           ` Christoph Lameter
2006-06-08 23:03 ` [PATCH 06/14] Add per zone counters to zone node and global VM statistics Christoph Lameter
2006-06-08 23:03   ` Christoph Lameter
2006-06-09  4:01   ` Andrew Morton
2006-06-09  4:01     ` Andrew Morton
2006-06-09 15:55     ` Christoph Lameter
2006-06-09 15:55       ` Christoph Lameter
2006-06-08 23:03 ` [PATCH 07/14] Conversion of nr_slab to per zone counter Christoph Lameter
2006-06-08 23:03   ` Christoph Lameter
2006-06-08 23:03 ` [PATCH 08/14] Conversion of nr_pagetable " Christoph Lameter
2006-06-08 23:03   ` Christoph Lameter
2006-06-08 23:03 ` [PATCH 09/14] Conversion of nr_dirty " Christoph Lameter
2006-06-08 23:03   ` Christoph Lameter
2006-06-08 23:03 ` [PATCH 10/14] Conversion of nr_writeback " Christoph Lameter
2006-06-08 23:03   ` Christoph Lameter
2006-06-08 23:03 ` [PATCH 11/14] Conversion of nr_unstable " Christoph Lameter
2006-06-08 23:03   ` Christoph Lameter
2006-06-08 23:03 ` [PATCH 12/14] Remove unused get_page_stat functions Christoph Lameter
2006-06-08 23:03   ` Christoph Lameter
2006-06-08 23:03 ` [PATCH 13/14] Conversion of nr_bounce to per zone counter Christoph Lameter
2006-06-08 23:03   ` Christoph Lameter
2006-06-08 23:03 ` [PATCH 14/14] Remove useless writeback structure Christoph Lameter
2006-06-08 23:03   ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1149844934.20886.41.camel@lappy \
    --to=a.p.zijlstra@chello.nl \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=clameter@sgi.com \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.