From: Nathaniel Case <ncase@xes-inc.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Andy Fleming <afleming@freescale.com>,
netdev@vger.kernel.org, galak@kernel.crashing.org
Subject: Re: [PATCH 1/2] PHYLIB: Add get_link ethtool helper function
Date: Mon, 12 Jun 2006 11:12:04 -0500 [thread overview]
Message-ID: <1150128725.30343.36.camel@localhost.localdomain> (raw)
In-Reply-To: <448C4131.3000504@garzik.org>
On Sun, 2006-06-11 at 12:13 -0400, Jeff Garzik wrote:
> > This adds a phy_ethtool_get_link() function along the same lines as
> > phy_ethtool_gset(). This provides drivers utilizing PHYLIB an
> > alternative to using ethtool_op_get_link(). This is more desirable
> > since the "Link detected" field in ethtool would actually reflect the
> > state of the PHY register.
> >
[snip]
> NAK, needs an EXPORT
In that case, shouldn't we EXPORT phy_ethtool_sset() and
phy_ethtool_gset() in drivers/net/phy/phy.c as well?
- Nate Case <ncase@xes-inc.com>
prev parent reply other threads:[~2006-06-12 16:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-05 23:48 [PATCH 1/2] PHYLIB: Add get_link ethtool helper function Nathaniel Case
2006-06-11 16:13 ` Jeff Garzik
2006-06-12 16:12 ` Nathaniel Case [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150128725.30343.36.camel@localhost.localdomain \
--to=ncase@xes-inc.com \
--cc=afleming@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.