From: Wei Dong <weid@nanjing-fnst.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net
Subject: [patch] e100 statistic value "rx_bytes" error
Date: Thu, 15 Jun 2006 12:17:06 +0800 [thread overview]
Message-ID: <1150345027.3008.10.camel@L-tech> (raw)
Hi All:
When I test linux kernel(2.6.9-16), I found that maybe there is a bug
in e100 driver. See function e100_rx_indicate() at line 1847:
nic->net_stats.rx_bytes += actual_size;
Here, actual_size is the actual size of an ethernent frame sans FCS.And
the e100 driver gets it from skb. Because "rx_bytes" is a statistc value
for a NIC, I think rx_bytes should include the FCS(4 bytes).
The following is the patch for the function in e100.c
diff -ruN old/drivers/net/e100.c new/drivers/net/e100.c
--- old/drivers/net/e100.c 2006-03-20 13:53:29.000000000 +0800
+++ new/drivers/net/e100.c 2006-06-15 11:16:04.000000000 +0800
@@ -1844,7 +1844,8 @@
dev_kfree_skb_any(skb);
} else {
nic->net_stats.rx_packets++;
- nic->net_stats.rx_bytes += actual_size;
+ /* Don't forget FCS */
+ nic->net_stats.rx_bytes += actual_size + 4;
nic->netdev->last_rx = jiffies;
netif_receive_skb(skb);
if(work_done)
BR.
Weidong
Signed-off-by: Weidong <weid@nanjing-fnst.com>
next reply other threads:[~2006-06-15 4:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-15 4:17 Wei Dong [this message]
2006-06-15 4:35 ` [patch] e100 statistic value "rx_bytes" error Auke Kok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150345027.3008.10.camel@L-tech \
--to=weid@nanjing-fnst.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.