From: Hong Liu <hong.liu@intel.com>
To: linville@tuxdriver.com
Cc: netdev@vger.kernel.org
Subject: [patch] ieee80211: fix not allocating IV+ICV space when using encryption in ieee80211_tx_frame
Date: Tue, 20 Jun 2006 10:26:34 +0800 [thread overview]
Message-ID: <1150770394.26493.47.camel@devlinux-hong> (raw)
[-- Attachment #1: Type: text/plain, Size: 199 bytes --]
We should preallocate IV+ICV space when encrypting the frame.
Currently no problem shows up just because dev_alloc_skb aligns the
data len to SMP_CACHE_BYTES which can be used for ICV.
Thanks,
Hong
[-- Attachment #2: ieee80211-1.1.14-newtxfix.patch --]
[-- Type: text/x-patch, Size: 1620 bytes --]
diff -urp a/net/ieee80211/ieee80211_tx.c b/net/ieee80211/ieee80211_tx.c
--- a/net/ieee80211/ieee80211_tx.c 2006-06-20 09:36:13.000000000 +0800
+++ b/net/ieee80211/ieee80211_tx.c 2006-06-20 09:32:39.000000000 +0800
@@ -562,10 +562,12 @@ int ieee80211_tx_frame(struct ieee80211_
struct net_device_stats *stats = &ieee->stats;
struct sk_buff *skb_frag;
int priority = -1;
+ int fraglen = total_len;
+ struct ieee80211_crypt_data *crypt = ieee->crypt[ieee->tx_keyidx];
spin_lock_irqsave(&ieee->lock, flags);
- if (encrypt_mpdu && !ieee->sec.encrypt)
+ if (encrypt_mpdu && (!ieee->sec.encrypt || !crypt))
encrypt_mpdu = 0;
/* If there is no driver handler to take the TXB, dont' bother
@@ -581,20 +583,25 @@ int ieee80211_tx_frame(struct ieee80211_
goto success;
}
- if (encrypt_mpdu)
+ if (encrypt_mpdu) {
frame->frame_ctl |= cpu_to_le16(IEEE80211_FCTL_PROTECTED);
+ /* mpdu_prefix_len will be add to the headroom */
+ fraglen += crypt->ops->extra_mpdu_postfix_len;
+ }
/* When we allocate the TXB we allocate enough space for the reserve
* and full fragment bytes (bytes_per_frag doesn't include prefix,
* postfix, header, FCS, etc.) */
- txb = ieee80211_alloc_txb(1, total_len, ieee->tx_headroom, GFP_ATOMIC);
+ txb = ieee80211_alloc_txb(1, fraglen, ieee->tx_headroom +
+ crypt->ops->extra_mpdu_prefix_len,
+ GFP_ATOMIC);
if (unlikely(!txb)) {
printk(KERN_WARNING "%s: Could not allocate TXB\n",
ieee->dev->name);
goto failed;
}
txb->encrypted = 0;
- txb->payload_size = total_len;
+ txb->payload_size = fraglen;
skb_frag = txb->fragments[0];
next reply other threads:[~2006-06-20 2:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 2:26 Hong Liu [this message]
2006-06-21 3:35 ` [patch] ieee80211: fix not allocating IV+ICV space when usingencryption in ieee80211_tx_frame Hong Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150770394.26493.47.camel@devlinux-hong \
--to=hong.liu@intel.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.