From: "Michael Chan" <mchan@broadcom.com>
To: "Herbert Xu" <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [2/5] [NET]: Add generic segmentation offload
Date: Tue, 20 Jun 2006 10:54:48 -0700 [thread overview]
Message-ID: <1150826089.17133.14.camel@rh4> (raw)
In-Reply-To: <20060620092840.GB31854@gondor.apana.org.au>
On Tue, 2006-06-20 at 19:28 +1000, Herbert Xu wrote:
> [NET]: Add generic segmentation offload
>
> +static int dev_gso_segment(struct sk_buff *skb)
> +{
> + struct sk_buff *segs;
> +
> + segs = skb_gso_segment(skb, skb->dev->features & NETIF_F_SG &&
> + !illegal_highdma(dev, skb));
I think you need !illegal_highdma(skb->dev, skb)
next prev parent reply other threads:[~2006-06-20 17:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 9:09 [0/5] GSO: Generic Segmentation Offload Herbert Xu
2006-06-20 9:10 ` [1/5] [NET]: Merge TSO/UFO fields in sk_buff Herbert Xu
2006-06-21 21:48 ` Michael Chan
2006-06-21 23:27 ` Herbert Xu
2006-06-22 0:46 ` Michael Chan
2006-06-22 1:09 ` Herbert Xu
2006-06-22 1:14 ` David Miller
2006-06-20 9:28 ` [2/5] [NET]: Add generic segmentation offload Herbert Xu
2006-06-20 17:54 ` Michael Chan [this message]
2006-06-20 23:46 ` Herbert Xu
2006-06-20 9:29 ` [3/5] [NET]: Add software TSOv4 Herbert Xu
2006-06-20 9:30 ` [4/5] [NET]: Added GSO toggle Herbert Xu
2006-06-20 9:30 ` [5/5] [IPSEC]: Handle GSO packets Herbert Xu
2006-06-20 9:32 ` [0/5] GSO: Generic Segmentation Offload Herbert Xu
2006-06-20 10:40 ` David Miller
2006-06-20 16:18 ` Rick Jones
-- strict thread matches above, loose matches on Subject: below --
2006-06-22 8:12 Herbert Xu
2006-06-22 8:13 ` [2/5] [NET]: Add generic segmentation offload Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150826089.17133.14.camel@rh4 \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.