All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Alexander Belyakov <abelyako@googlemail.com>
Cc: Linux MTD mailing list <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] NAND: fix nand_write_oob_std return value
Date: Wed, 21 Jun 2006 13:43:02 +0200	[thread overview]
Message-ID: <1150890182.6780.356.camel@localhost.localdomain> (raw)
In-Reply-To: <fe810cf0606210436w7196e009o82ac67a86e41ee9c@mail.gmail.com>

On Wed, 2006-06-21 at 15:36 +0400, Alexander Belyakov wrote:
> It seems nand_write_oob_std should not return just status value
> 
> Signed-off-by: Alexander Belyakov <alexander.belyakov@intel.com>
> 
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 27083ed..79eae5d 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -1176,7 +1176,7 @@ static int nand_write_oob_std(struct mtd
> 
>  	status = chip->waitfunc(mtd, chip);
> 
> -	return status;
> +	return status & NAND_STATUS_FAIL ? -EIO : 0;
>  }

You are the second one to notice. Already fixed.

Thanks anyway,

	tglx


	

  reply	other threads:[~2006-06-21 11:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-21 11:36 [PATCH] NAND: fix nand_write_oob_std return value Alexander Belyakov
2006-06-21 11:43 ` Thomas Gleixner [this message]
2006-06-21 12:03 ` Vitaly Wool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1150890182.6780.356.camel@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=abelyako@googlemail.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.