Re: [PATCH] libselinux: 1/2 Introduce {get,set}procattrcon

[James Antill <jantill@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2340 bytes --]

On Fri, 2006-06-23 at 16:32 -0400, Eric Paris wrote:
> The below attached patch implements two new function, get and set
> procattrcon.  These are generic functions that take a context and a path
> and attempt to write that context to that path.  These are used by of
> exported libselinux interfaces, like getfscreatecon, as a generic
> backend to reduce duplication of code.

> --- libselinux-1.30.15/src/setprocattrcon.c.p1	2006-06-23 15:05:25.000000000 -0400
> +++ libselinux-1.30.15/src/setprocattrcon.c	2006-06-23 15:10:05.000000000 -0400
> @@ -0,0 +1,40 @@
> +#include <unistd.h>
> +#include <string.h>
> +#include <fcntl.h>
> +#include "selinux_internal.h"
> +
> +int setprocattrcon_raw(char *context, char *proc_entry)
> +{
> +	int fd;
> +	ssize_t ret;
> +
> +	fd = open(proc_entry, O_RDWR);
> +	if (fd < 0)
> +		return -1;
> +	if (context) 
> +		ret = write(fd, context, strlen(context)+1);
> +	else
> +		ret = write(fd, NULL, 0); /* clear */
> +	close(fd);

 Could you save and restore errno around the close? I know it didn't do
that before, but still...

> +	if (ret < 0)
> +		return -1;
> +	else
> +		return 0;
> +}
> +hidden_def(setprocattrcon_raw)
[...]
> +hidden_def(setprocattrcon)

 These make it impossible to call those functions from outside the
shared library, but you've declared them in the external header.

> --- libselinux-1.30.15/include/selinux/selinux.h.p1	2006-06-23 15:05:25.000000000 -0400
> +++ libselinux-1.30.15/include/selinux/selinux.h	2006-06-23 15:20:06.000000000 -0400
> @@ -24,6 +24,14 @@ extern void freeconary(security_context_
>  
>  /* Wrappers for the /proc/pid/attr API. */
>  
> +/* Generic /proc pid attr handlers.  These will either get or set the context
> +   from or into the proc location passed to them.  Should only be called from 
> +   inside libselinux */
> +extern int getprocattrcon(security_context_t *con, char *path);
> +extern int getprocattrcon_raw(security_context_t *con, char *path);
> +extern int setprocattrcon(security_context_t con, char *path);
> +extern int setprocattrcon_raw(security_context_t con, char *path);
> +
>  /* Get current context, and set *con to refer to it.
>     Caller must free via freecon. */
>  extern int getcon(security_context_t *con);

-- 
James Antill <jantill@redhat.com>

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]