From: Johannes Berg <johannes@sipsolutions.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] convert powermac ide blink to new led infrastructure
Date: Tue, 27 Jun 2006 19:31:23 +0200 [thread overview]
Message-ID: <1151429483.597.12.camel@localhost> (raw)
In-Reply-To: <1151394629.2350.64.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
> Looks good. Only one nit: in pmu_led_set(), you should be able to test
> if the requested state is identical to the current one and do nothing
> without taking the lock no ?
>
> Or does the upper level LED infrastructure takes care of it ?
I don't know, Richard? But yeah, I can do that too.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]
next prev parent reply other threads:[~2006-06-27 17:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-06 23:05 [PATCH] convert powermac ide blink to new led infrastructure Johannes Berg
2006-06-08 0:28 ` Benjamin Herrenschmidt
2006-06-09 11:47 ` Johannes Berg
2006-06-09 11:56 ` Anton Blanchard
2006-06-09 12:01 ` Johannes Berg
2006-06-21 10:11 ` Johannes Berg
2006-06-27 7:50 ` Benjamin Herrenschmidt
2006-06-27 17:31 ` Johannes Berg [this message]
2006-06-28 9:38 ` Richard Purdie
2006-06-28 9:43 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2006-04-28 14:49 Johannes Berg
2006-04-28 15:15 ` Johannes Berg
2006-04-29 9:27 ` Johannes Berg
2006-05-01 6:56 ` Benjamin Herrenschmidt
2006-05-01 8:59 ` Johannes Berg
2006-05-01 9:10 ` Benjamin Herrenschmidt
2006-05-01 9:25 ` Johannes Berg
2006-05-01 9:35 ` Benjamin Herrenschmidt
2006-05-01 21:19 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151429483.597.12.camel@localhost \
--to=johannes@sipsolutions.net \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.