From: Eric Sesterhenn <snakebyte@gmx.de>
To: linux-kernel@vger.kernel.org
Cc: Henk.Vergonet@gmail.com
Subject: [Patch] Off by one in drivers/usb/input/yealink.c
Date: Wed, 28 Jun 2006 00:41:19 +0200 [thread overview]
Message-ID: <1151448080.16217.3.camel@alice> (raw)
hi,
another off by one spotted by coverity (id #485),
we loop exactly one time too often
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-git11/drivers/usb/input/yealink.c.orig 2006-06-28 00:29:46.000000000 +0200
+++ linux-2.6.17-git11/drivers/usb/input/yealink.c 2006-06-28 00:30:04.000000000 +0200
@@ -350,7 +350,7 @@ static int yealink_do_idle_tasks(struct
val = yld->master.b[ix];
if (val != yld->copy.b[ix])
goto send_update;
- } while (++ix < sizeof(yld->master));
+ } while (++ix < sizeof(yld->master)-1);
/* nothing todo, wait a bit and poll for a KEYPRESS */
yld->stat_ix = 0;
next reply other threads:[~2006-06-27 22:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-27 22:41 Eric Sesterhenn [this message]
2006-06-27 22:51 ` [Patch] Off by one in drivers/usb/input/yealink.c Randy.Dunlap
2006-06-27 23:04 ` Eric Sesterhenn / Snakebyte
2006-06-27 23:18 ` Randy.Dunlap
2006-06-27 23:26 ` Eric Sesterhenn
2006-07-05 13:02 ` Henk Vergonet
[not found] ` <d120d5000607050655o44cb66c3s7616493c7507d4d8@mail.gmail.com>
2006-07-06 0:49 ` Eric Sesterhenn / Snakebyte
2006-07-06 2:25 ` Dmitry Torokhov
2006-07-06 14:41 ` Eric Sesterhenn / Snakebyte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151448080.16217.3.camel@alice \
--to=snakebyte@gmx.de \
--cc=Henk.Vergonet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.