From: Eric Wong <normalperson@yhbt.net>
To: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Cc: Eric Wong <normalperson@yhbt.net>
Subject: [PATCH 1/2] rebase: check for errors from git-commit
Date: Wed, 28 Jun 2006 02:11:05 -0700 [thread overview]
Message-ID: <11514858662929-git-send-email-normalperson@yhbt.net> (raw)
commit does not always succeed, so we'll have to check for
it in the absence of set -e. This fixes a regression
introduced in 9e4bc7dd1bb9d92491c475cec55147fa0b3f954d
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
I've grown used to having 'set -e' at the beginning of my shell
scripts. IMHO it'd be a good idea to start moving towards this
eventually (even though shell scripts seem to be getting phased-out
somewhat).
git-rebase.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-rebase.sh b/git-rebase.sh
index 9ad1c44..47c8e8f 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -59,8 +59,8 @@ continue_merge () {
if test -n "`git-diff-index HEAD`"
then
+ git-commit -C "`cat $dotest/current`" || die 'Commit failed'
printf "Committed: %0${prec}d" $msgnum
- git-commit -C "`cat $dotest/current`"
else
printf "Already applied: %0${prec}d" $msgnum
fi
--
1.4.1.rc1.g3cc8
next reply other threads:[~2006-06-28 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 9:11 Eric Wong [this message]
2006-06-28 9:11 ` [PATCH 2/2] rebase: get rid of outdated MRESOLVEMSG Eric Wong
2006-06-28 9:25 ` [PATCH 1/2] rebase: check for errors from git-commit Junio C Hamano
2006-06-28 9:33 ` Eric Wong
2006-06-28 9:49 ` Junio C Hamano
2006-06-28 9:54 ` Eric Wong
2006-06-28 9:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11514858662929-git-send-email-normalperson@yhbt.net \
--to=normalperson@yhbt.net \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.