All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: Quick merge status updates.
Date: Wed, 28 Jun 2006 06:05:03 -0400	[thread overview]
Message-ID: <1151489103.28036.6.camel@dv> (raw)
In-Reply-To: <7v7j3164xd.fsf@assigned-by-dhcp.cox.net>

On Wed, 2006-06-28 at 01:49 -0700, Junio C Hamano wrote:

> I suspect this is either FC perl-dev package is broken (I doubt
> it) or your installation procedure is pecurilar (much more
> likely).  I pass the same set of prefix, bindir and friends to
> "make" and "make install" and do not see the problem.

I think my Perl 5.8.8 is "too new".  "man perlfunc" says about "use":

"Imports some semantics into the current package from the named module,
generally by aliasing certain subroutine or variable names into your
package.  It is exactly equivalent to

      BEGIN { require Module; import Module LIST; }

except that Module must be a bareword."

I think the BEGIN block has priority over other statements.  My solution
was to put the @INC change in the BEGIN block as well.

This patch is working for me:

diff --git a/git-fmt-merge-msg.perl b/git-fmt-merge-msg.perl
index e8fad02..1b23fa1 100755
--- a/git-fmt-merge-msg.perl
+++ b/git-fmt-merge-msg.perl
@@ -5,7 +5,7 @@ #
 # Read .git/FETCH_HEAD and make a human readable merge message
 # by grouping branches and tags together to form a single line.
 
-unshift @INC, '@@INSTLIBDIR@@';
+BEGIN { unshift @INC, '@@INSTLIBDIR@@'; }
 use strict;
 use Git;
 use Error qw(:try);


-- 
Regards,
Pavel Roskin

  reply	other threads:[~2006-06-28 10:05 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-28  0:23 Quick merge status updates Junio C Hamano
2006-06-28  5:04 ` Pavel Roskin
2006-06-28  8:49   ` Junio C Hamano
2006-06-28 10:05     ` Pavel Roskin [this message]
2006-06-28 10:14       ` Junio C Hamano
2006-07-02 20:49       ` Petr Baudis
2006-07-02 21:33         ` Junio C Hamano
2006-07-02 21:49           ` Petr Baudis
2006-07-02 22:50             ` Junio C Hamano
2006-07-02 23:49               ` Junio C Hamano
2006-07-03  0:00                 ` Linus Torvalds
2006-07-03  0:06                   ` Junio C Hamano
2006-07-03 20:29                 ` Petr Baudis
2006-07-03 21:16                   ` [PATCH] Use $GITPERLLIB instead of $RUNNING_GIT_TESTS and centralize @INC munging Petr Baudis
2006-07-08  7:36         ` Quick merge status updates Pavel Roskin
2006-06-28  7:32 ` Johannes Schindelin
2006-06-28  7:39   ` Johannes Schindelin
2006-06-28  8:51     ` Junio C Hamano
2006-06-28  9:13       ` Johannes Schindelin
2006-07-01 23:48     ` [PATCH] Git.pm: Avoid ppport.h Petr Baudis
2006-07-02  9:52       ` Johannes Schindelin
2006-07-02 19:05         ` Junio C Hamano
2006-07-02 20:57           ` [PATCH] Git.pm: Don't #define around die Petr Baudis
  -- strict thread matches above, loose matches on Subject: below --
2006-07-02 21:40 Making perl scripts include the correct Git.pm Petr Baudis
2006-07-03  0:02 ` Junio C Hamano
2006-07-03  1:38   ` Junio C Hamano
2006-07-04 19:01     ` Marco Costalba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1151489103.28036.6.camel@dv \
    --to=proski@gnu.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.