From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: tglx@linutronix.de
Cc: David Miller <davem@davemloft.net>,
rmk+lkml@arm.linux.org.uk, mingo@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: SA_TRIGGER_* vs. SA_SAMPLE_RANDOM
Date: Sat, 01 Jul 2006 10:14:02 +1000 [thread overview]
Message-ID: <1151712843.27137.20.camel@localhost.localdomain> (raw)
In-Reply-To: <1151706327.25491.847.camel@localhost.localdomain>
On Sat, 2006-07-01 at 00:25 +0200, Thomas Gleixner wrote:
> On Fri, 2006-06-30 at 13:31 -0700, David Miller wrote:
> > From: Thomas Gleixner <tglx@linutronix.de>
> > Date: Fri, 30 Jun 2006 22:27:27 +0200
> >
> > > I'll cook it up tomorrow.
> >
> > Thanks a lot Thomas. :)
>
> That's what I came up with:
>
> SA_INTERRUPT IRQF_IRQS_DISABLED
> SA_SAMPLE_RANDOM IRQF_SAMPLE_RANDOM
> SA_SHIRQ IRQF_SHARE_IRQ
> SA_PROBEIRQ IRQF_PROBE_IRQ
> SA_TRIGGER_LOW IRQF_TRIGGER_LOW
> SA_TRIGGER_HIGH IRQF_TRIGGER_HIGH
> SA_TRIGGER_FALLING IRQF_TRIGGER_FALLING
> SA_TRIGGER_RISING IRQF_TRIGGER_RISING
> SA_TRIGGER_MASK IRQF_TRIGGER_MASK
> SA_TIMER IRQF_TIMER
Looks good to me. Do we want to keep a PERCPU flag too ? I don't really
need it anymore on powerpc as I just use the percpu flow handler and I'm
not allowing sharing of IPIs but others might.
Also, I'd like to store the IRQ types in the irq_desc regardless of the
actions that have been registered or not. Any suggestion where to put
that ? The current type values conflict with other desc->status bits at
the moment unless we shift the whole thing up...
Ben.
next prev parent reply other threads:[~2006-07-01 0:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-29 21:17 SA_TRIGGER_* vs. SA_SAMPLE_RANDOM David Miller
2006-06-30 14:00 ` Thomas Gleixner
2006-06-30 18:47 ` Russell King
2006-06-30 20:21 ` David Miller
2006-06-30 20:27 ` Thomas Gleixner
2006-06-30 20:31 ` David Miller
2006-06-30 22:25 ` Thomas Gleixner
2006-07-01 0:14 ` Benjamin Herrenschmidt [this message]
2006-07-01 0:10 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151712843.27137.20.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.