From: jamal <hadi@cyberus.ca>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org, davem@davemloft.net, Thomas Graf <tgraf@suug.ch>
Subject: Re: [PATCH 1/3] [PKT_SCHED]: Fix illegal memory dereferences when dumping actions
Date: Tue, 04 Jul 2006 21:49:27 -0400 [thread overview]
Message-ID: <1152064167.5199.14.camel@jzny2> (raw)
In-Reply-To: <44AAFCF6.9000706@trash.net>
On Wed, 2006-05-07 at 01:42 +0200, Patrick McHardy wrote:
> Thomas Graf wrote:
> > if (a_o->walk == NULL) {
> > - printk("tc_dump_action: %s !capable of dumping table\n", kind);
> > + printk("tc_dump_action: %s !capable of dumping table\n", a_o->kind);
> > goto rtattr_failure;
> > }
>
> Can't we just get rid of these printks? This seems like a good
> opportunity.
>
perhaps convert to DPRINTKs instead
cheers,
jamal
next prev parent reply other threads:[~2006-07-05 1:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-04 22:05 [PATCH 0/3] Action API fixes Thomas Graf
2006-07-04 22:00 ` [PATCH 1/3] [PKT_SCHED]: Fix illegal memory dereferences when dumping actions Thomas Graf
2006-07-04 23:42 ` Patrick McHardy
2006-07-05 1:49 ` jamal [this message]
2006-07-05 9:09 ` Thomas Graf
2006-07-05 1:34 ` jamal
2006-07-04 22:00 ` [PATCH 2/3] [PKT_SCHED]: Return ENOENT if action module is unavailable Thomas Graf
2006-07-05 1:40 ` jamal
2006-07-04 22:00 ` [PATCH 3/3] [PKT_SCHED]: Fix error handling while dumping actions Thomas Graf
2006-07-05 1:47 ` jamal
2006-07-05 13:35 ` jamal
2006-07-05 13:54 ` Thomas Graf
2006-07-05 14:00 ` jamal
2006-07-06 3:47 ` [PATCH 0/3] Action API fixes David Miller
2006-07-06 12:03 ` jamal
2006-07-06 12:27 ` jamal
2006-07-06 12:45 ` Thomas Graf
2006-07-06 12:53 ` jamal
2006-07-07 6:56 ` David Miller
2006-07-07 6:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1152064167.5199.14.camel@jzny2 \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.