From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harry Butterworth Subject: Re: Xen Management API Draft, version 0.4 Date: Fri, 07 Jul 2006 14:16:45 +0100 Message-ID: <1152278206.7717.47.camel@localhost.localdomain> References: <20060703155332.GA5002@leeni.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060703155332.GA5002@leeni.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ewan Mellor Cc: Xen-devel List-Id: xen-devel@lists.xenproject.org I may be misreading the document but it seems to me like you've constrained the class definition such that all of the construtor parameters have accessor methods. I think this may be a bit unnatural and I think any required accessor methods for constructor parameters are just a special case of accessor methods required in general and they in turn are just a special case of general purpose methods like the ones required to drive the vm lifecycle. A bit of googling turned up this article on accessors which I tend to agree with for the most part: http://www.javaworld.com/javaworld/jw-09-2003/jw-0905-toolbox.html Harry.