All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Haren Myneni <haren@us.ibm.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc: EOI and clear IPI fix in xics_teardown_cpu()
Date: Sun, 09 Jul 2006 11:37:07 +1000	[thread overview]
Message-ID: <1152409027.4128.14.camel@localhost.localdomain> (raw)
In-Reply-To: <44B05BD0.304@us.ibm.com>

On Sat, 2006-07-08 at 18:28 -0700, Haren Myneni wrote:
> If OK, please sent this patch to upstream.
> 
> Thanks
> Haren
> 
> When invoked kdump boot, plpar_eoi() call is getting failed and calling 
> panic().
> Kernel panic - not syncing: bad return code EOI - rc = -4, value=ff000000
> 
> The issue is with the desc->chip->eoi(XICS_IPI) in xics_teardown_cpu(). 
> Instead of passing the virq to desc->chip->eoi(), XICS_IPI is used. 
> Also, clear IPI in xics_teardown_cpu() got removed recently (in 
> 2.6.17-git25).  Noticed in some crash dump cases (Ex: initiate kdump 
> boot using soft-reset and xmon is enabled), IPI is not cleared for some 
> CPU(s) before starting the kdump boot. Hence, causing the kdump boot 
> failure.

It's already fixed in my latest patch that fixes some issues with the
new irq rework. Hopefully, paul will send the patch upstream tomorrow
after we had a chance to test it a bit more.

Cheers,
Ben

  reply	other threads:[~2006-07-09  1:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-09  1:28 [PATCH] powerpc: EOI and clear IPI fix in xics_teardown_cpu() Haren Myneni
2006-07-09  1:37 ` Benjamin Herrenschmidt [this message]
2006-07-09  2:17   ` Haren Myneni
2006-07-09  4:08     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1152409027.4128.14.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=haren@us.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.