From: Thomas Gleixner <tglx@linutronix.de>
To: Mike Rapoport <mike@compulab.co.il>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] CM-x2xx NAND flash support
Date: Tue, 11 Jul 2006 10:23:53 +0200 [thread overview]
Message-ID: <1152606233.32107.98.camel@localhost.localdomain> (raw)
In-Reply-To: <44B36563.9050103@compulab.co.il>
On Tue, 2006-07-11 at 10:46 +0200, Mike Rapoport wrote:
> >>+ unsigned int nandaddr = (unsigned int)this->IO_ADDR_W;
> >>
> >>
> >
> >what the hell is this type cast for ?
> >
> > void __iomem *nandaddr =
> >
> >
> you can't do |= and &= with void __iomem*
Err, why not ?
> >Can you please combine both drivers into one and make it a platform
> >device. There is no need to keep lots of duplicate functionality around.
> >
> I'm dropping cm-x255 support (management decision) so there's only one
> platform that can use this driver. What's the point then?
Sorry man, you submitted _two_ drivers in the first place and I did the
review on those. I'm not good at witchcrafting the decisions of your
management.
tglx
next prev parent reply other threads:[~2006-07-11 8:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-06 12:48 [PATCH] CM-x2xx NAND flash support Mike Rapoport
2006-07-09 9:26 ` Thomas Gleixner
2006-07-11 8:46 ` Mike Rapoport
2006-07-11 8:10 ` Wolfgang Mües
2006-07-11 11:32 ` Mike Rapoport
2006-07-11 8:23 ` Thomas Gleixner [this message]
2006-07-11 12:36 ` Mike Rapoport
2006-07-12 13:21 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1152606233.32107.98.camel@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.