From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Andrew D. Ball" Subject: Re: [RFC] [PATCH] HVM SMBIOS support 1/6 Date: Tue, 11 Jul 2006 15:27:51 -0400 Message-ID: <1152646072.5663.21.camel@localhost.localdomain> References: <1152301009.7155.8.camel@localhost.localdomain> <442fabca27c99ca77e25120f23a73bbc@cl.cam.ac.uk> <1152641541.5663.6.camel@localhost.localdomain> <425338b80088758ffe25b230cf126129@cl.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <425338b80088758ffe25b230cf126129@cl.cam.ac.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tue, 2006-07-11 at 19:34 +0100, Keir Fraser wrote: > On 11 Jul 2006, at 19:12, Andrew D. Ball wrote: > > > Do you see any other things to work on for the SMBIOS patches? Making > > SMBIOS not optional cuts down on a bit of the code, so I'm working on > > that and getting the code to run on the latest changeset today. > > I think they're basically okay. I find it a bit weird that hvmloader > puts SMBIOS tables in a fixed place and then rombios copies them -- not > sure why that's needed but I suppose you're only copying what is done > for ACPI tables. Couldn't hvmloader write all BIOS tables to a safe > location and be done with them, or is the problem that 0xf0000 upwards > is not available at the time hvmloader runs? More or less. 0xf0000-0xfffff is reserved for the ROMBIOS, but I need a 31-bit entry point somewhere on a 16-byte boundary there. It's only the 31-bit entry point that gets copied. > Also, is the e820 > reservation entry actually valid: 0x9f000-0xA0000 is reserved, but > rombios copies the tables out of that area, right? Does rombios also > update the e820 table? I'm a little confused about this myself. Whenever I change the e820 map in libxenguest, it seems to work, but I see two other places that might change it (1) copy_e820_table in rombios.c -- looks like this doesn't do anything if 0x91e8 is 0, which is probably the case. (2) some code in vmxassist's setup.c -- looks like this has a copy of the same e820map defined in xc_hvm_build.c and only changes it if TEST is defined. Thanks for your help! Andrew > > -- Keir > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >