From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Vladimir V. Saveliev" Subject: Re: reiser4 OOPSes and panics when out of memory Date: Wed, 19 Jul 2006 18:07:17 +0400 Message-ID: <1153318037.6383.68.camel@tribesman.namesys.com> References: <63591.70.224.221.228.1153071893.squirrel@people.msoe.edu> <1153145428.6311.43.camel@tribesman.namesys.com> <1153157891.6311.71.camel@tribesman.namesys.com> <1153205527.9866.20.camel@gentoo> <1153232327.6355.41.camel@tribesman.namesys.com> <1153315682.9708.5.camel@gentoo> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-vJQQbPGoAi5rt36Q67Pe" Return-path: list-help: list-unsubscribe: list-post: Errors-To: flx@namesys.com In-Reply-To: <1153315682.9708.5.camel@gentoo> List-Id: To: Jake Maciejewski Cc: reiserfs-list@namesys.com --=-vJQQbPGoAi5rt36Q67Pe Content-Type: text/plain Content-Transfer-Encoding: 7bit Hello On Wed, 2006-07-19 at 07:28 -0600, Jake Maciejewski wrote: > Thanks. Now with debug enabled I've gotten: > > http://people.msoe.edu/~maciejej/patches/AMD64_reiser4_debug/20060719/panic1.txt.gz the attached patch fixes a problem nikita-2967 reports about. Would you please check whther it helps. > http://people.msoe.edu/~maciejej/patches/AMD64_reiser4_debug/20060719/fsck1_--check.txt.gz > http://people.msoe.edu/~maciejej/patches/AMD64_reiser4_debug/20060719/fsck1_--fix.txt.gz > http://people.msoe.edu/~maciejej/patches/AMD64_reiser4_debug/20060719/fsck1_--check_after_--fix.txt.gz > > and > > http://people.msoe.edu/~maciejej/patches/AMD64_reiser4_debug/20060719/messages2.txt.gz > followed by > http://people.msoe.edu/~maciejej/patches/AMD64_reiser4_debug/20060719/messages2b.txt.gz > > and without debug: > > http://people.msoe.edu/~maciejej/patches/AMD64_reiser4_debug/20060719/messages3.txt.gz > http://people.msoe.edu/~maciejej/patches/AMD64_reiser4_debug/20060719/fsck3_--check.txt.gz > http://people.msoe.edu/~maciejej/patches/AMD64_reiser4_debug/20060719/fsck3_--fix.txt.gz > http://people.msoe.edu/~maciejej/patches/AMD64_reiser4_debug/20060719/fsck3_--check_after_--fix.txt.gz > > On Tue, 2006-07-18 at 18:18 +0400, Vladimir V. Saveliev wrote: > > Hello > > > > On Tue, 2006-07-18 at 00:52 -0600, Jake Maciejewski wrote: > > > Thanks for the patch, but I can still reproduce the problem. I've been > > > running the attached program to try to speed up the testing process a > > > bit. Interrupting and restarting the compilation loop also seems to > > > help. > > > > > > > ok > > > > > If I had hours to wait, it would probably crash eventually without > > > additional encouragement, but I'm doing everything as an unprivileged > > > user, so I don't think my tests are unreasonable. > > > > > > Anyway, I'm still getting a panic with debug enabled: > > > > > > reiser4 panicked cowardly: reiser4[find(16411)]: reiser4_dirty_inode (fs/reiser4/super_ops.c:173)[]: > > > Kernel panic - not syncing: reiser4[find(16411)]: reiser4_dirty_inode (fs/reiser4/super_ops.c:173)[]: > > > > > > > The attached patch should fix the above. > > > > > Without debug enabled I've seen: > > > > > > http://people.msoe.edu/~maciejej/patches/AMD64_reiser4_debug/20060718/messages1.txt.gz > > > http://people.msoe.edu/~maciejej/patches/AMD64_reiser4_debug/20060718/fsck1_--check.txt.gz > > > http://people.msoe.edu/~maciejej/patches/AMD64_reiser4_debug/20060718/fsck1_--fix.txt.gz > > > http://people.msoe.edu/~maciejej/patches/AMD64_reiser4_debug/20060718/fsck1_--check_after_--fix.txt.gz > > > > > > but usually I get: > > > > > > http://people.msoe.edu/~maciejej/patches/AMD64_reiser4_debug/20060718/messages3.txt.gz > > > > > > with no corruption (although I've been rebooting before complete > > > failure). > > > > > > On Mon, 2006-07-17 at 21:38 +0400, Vladimir V. Saveliev wrote: > > > > Hello > > > > > > > > On Mon, 2006-07-17 at 18:10 +0400, Vladimir V. Saveliev wrote: > > > > > Hello > > > > > > > > > > On Sun, 2006-07-16 at 12:44 -0500, maciejej@msoe.edu wrote: > > > > > > Has my previous post > > > > > > (http://marc.theaimsgroup.com/?l=reiserfs&m=115259665831650&w=2) been > > > > > > overlooked, or have I not provided enough information? Do I need to > > > > > > reproduce these issues on 2.6.18-rc1-mm2? Should I be trying any patches? > > > > > > > > > > > > > > > > > > > please try the attached patch. > > > > > > > > > your test crashes reiser4 on my test box. I hope to get a patch ready > > > > > later today. Not sure that I got the same problem as you, though. We > > > > > will see. > > > > > > > > > > > The bottom line is with 2.6.17-mm6, I've always been able to OOPs or panic > > > > > > reiser4 on my amd64 machine (haven't tried x86 yet) by using all available > > > > > > physical memory. > > > > > > > > > > > > > > > > > > > > > > --=-vJQQbPGoAi5rt36Q67Pe Content-Description: Content-Disposition: inline; filename=reiser4-add-missing-unlock.patch Content-Type: text/x-patch; charset=utf-8 Content-Transfer-Encoding: 7bit diff -puN fs/reiser4/plugin/file/file.c~reiser4-add-missing-unlock fs/reiser4/plugin/file/file.c --- linux-2.6.17-mm6/fs/reiser4/plugin/file/file.c~reiser4-add-missing-unlock 2006-07-19 18:12:14.000000000 +0400 +++ linux-2.6.17-mm6-vs/fs/reiser4/plugin/file/file.c 2006-07-19 18:13:50.000000000 +0400 @@ -1636,14 +1636,18 @@ static size_t read_file(hint_t * hint, s /* error happened */ break; - if (coord->between != AT_UNIT) + if (coord->between != AT_UNIT) { /* there were no items corresponding to given offset */ + done_lh(hint->ext_coord.lh); break; + } loaded = coord->node; result = zload(loaded); - if (unlikely(result)) + if (unlikely(result)) { + done_lh(hint->ext_coord.lh); break; + } if (hint->ext_coord.valid == 0) validate_extended_coord(&hint->ext_coord, _ --=-vJQQbPGoAi5rt36Q67Pe--