All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Esben Nielsen <nielsen.esben@googlemail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch 3/3] [-rt] Fixes the timeout-bug in the rtmutex/PI-futex.
Date: Sun, 23 Jul 2006 12:05:11 -0400	[thread overview]
Message-ID: <1153670711.4002.9.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0607231756070.9903@localhost.localdomain>


> > haven't analyzed it enough yet.  But just so that you know that your
> > changes don't break the code, and to make it easier for me to look at
> > it. Please update Documentation/rt-mutex-design.txt including your
> > changes.  This will be a good exercise to see if it doesn't really break
> > anything, and it will give other reviewers a better starting point for
> > review.
> 
> Is that up-to-date in the -rt tree? The last patch you sent was to 
> 2.6.18-rc2, right?

Ah, you're right. I thought this was for mainline.  Didn't notice the
-rt in the subject.  Don't worry about documenting the -rt side of
things.  That is not stable enough to do so.  When portions of the rt
patch go to -mm, that will need to be documented. (willing to help in
this effort?)

I'll try later today to review your code a little deeper (no guarantees
since I just came home from Ottawa, and my family would like to see me a
little more).  I'm not sure if the semantics of the changes to the
sched.[ch] are correct, so I'll let Ingo comment on them.  I'll spend my
time looking at the changes to rtmutex.c.
 
-- Steve


      reply	other threads:[~2006-07-23 16:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060723005210.973833000@localhost>
2006-07-23  1:18 ` [patch 1/3] [-rt] Fixes the timeout-bug in the rtmutex/PI-futex Esben Nielsen
2006-07-23  1:18 ` [patch 2/3] " Esben Nielsen
2006-07-23  1:18 ` [patch 3/3] " Esben Nielsen
2006-07-23 14:57   ` Steven Rostedt
2006-07-23 16:58     ` Esben Nielsen
2006-07-23 16:05       ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1153670711.4002.9.camel@localhost.localdomain \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nielsen.esben@googlemail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.