From: Pavel Roskin <proski@gnu.org>
To: netdev@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>
Subject: Can we have GET_NETDEV_DEV?
Date: Tue, 25 Jul 2006 00:52:25 -0400 [thread overview]
Message-ID: <1153803145.23803.19.camel@dv> (raw)
Hello!
gregkh-driver-network-class_device-to-device.patch, which briefly
appeared in Linux 2.6.18-rc1-mm1 broke MadWifi, which is copying the
physical device information from the master network device to the
virtual network devices:
SET_NETDEV_DEV(dev, mdev->class_dev.dev);
The same code exists in hostap. The patch is gone from 2.6.18-rc1-mm2,
but I'd like to be prepared if it reappears.
An easy solution would be to have GET_NETDEV_DEV macro. Then the
drivers could do this:
SET_NETDEV_DEV(dev, GET_NETDEV_DEV(mdev));
without having to worry about the internals of struct net_device. It
should be done before class_dev is removed or in the same time.
Should I send a patch?
--
Regards,
Pavel Roskin
next reply other threads:[~2006-07-25 4:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-25 4:52 Pavel Roskin [this message]
2006-07-25 17:20 ` Can we have GET_NETDEV_DEV? Stephen Hemminger
2006-07-25 21:08 ` Pavel Roskin
2006-07-25 21:26 ` Stephen Hemminger
2006-07-25 22:02 ` Pavel Roskin
2006-07-25 21:31 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1153803145.23803.19.camel@dv \
--to=proski@gnu.org \
--cc=gregkh@suse.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.